Bug 232170 - Add support for rel="noopener/noreferrer" on <form> elements
Summary: Add support for rel="noopener/noreferrer" on <form> elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 232243
  Show dependency tree / graph
 
Reported: 2021-10-22 13:34 PDT by Chris Dumez
Modified: 2021-10-25 08:11 PDT (History)
15 users (show)

See Also:

Attachments
Patch (8.64 KB, patch)
2021-10-22 13:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.45 KB, patch)
2021-10-22 13:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (27.24 KB, patch)
2021-10-22 15:16 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (31.85 KB, patch)
2021-10-22 15:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (32.51 KB, patch)
2021-10-22 16:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.85 KB, patch)
2021-10-22 16:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.59 KB, patch)
2021-10-23 14:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-10-22 13:34:03 PDT 
Add support for rel="opener/noopener/noreferrer" on <form> elements.
Comment 1 Chris Dumez 2021-10-22 13:37:31 PDT 
Created attachment 442193 [details]
Patch
Comment 2 Chris Dumez 2021-10-22 13:55:35 PDT 
Created attachment 442196 [details]
Patch
Comment 3 Chris Dumez 2021-10-22 15:16:58 PDT 
Created attachment 442203 [details]
Patch
Comment 4 Chris Dumez 2021-10-22 15:32:06 PDT 
Created attachment 442204 [details]
Patch
Comment 5 Chris Dumez 2021-10-22 16:14:33 PDT 
Created attachment 442213 [details]
Patch
Comment 6 Chris Dumez 2021-10-22 16:38:00 PDT 
Created attachment 442222 [details]
Patch
Comment 7 Darin Adler 2021-10-23 06:13:31 PDT 
Comment on attachment 442222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442222&action=review

> Source/WebCore/html/HTMLFormElement.cpp:78
> +static FormRelAttributes parseFormRelAttributes(StringView relAttribute)

I would call this "string".

> Source/WebCore/html/HTMLFormElement.cpp:80
> +    FormRelAttributes relAttributes;

I would call this "attributes".
Comment 8 Chris Dumez 2021-10-23 14:41:00 PDT 
Created attachment 442280 [details]
Patch
Comment 9 EWS 2021-10-23 15:27:01 PDT 
Committed r284749 (243458@main): <https://commits.webkit.org/243458@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442280 [details].
Comment 10 Radar WebKit Bug Importer 2021-10-23 15:28:18 PDT 
<rdar://problem/84583172>