Bug 232137 - Factor style resolver context arguments into a struct
Summary: Factor style resolver context arguments into a struct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-22 03:04 PDT by Antti Koivisto
Modified: 2021-10-22 11:20 PDT (History)
23 users (show)

See Also:

Attachments
Patch (54.42 KB, patch)
2021-10-22 03:06 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (55.10 KB, patch)
2021-10-22 03:18 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (74.28 KB, patch)
2021-10-22 05:36 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (74.50 KB, patch)
2021-10-22 07:07 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (74.88 KB, patch)
2021-10-22 08:47 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-10-22 03:04:13 PDT 
Style resolver needs context to resolve things correctly. It is currently provided in an ad-hoc manner as a collection of function arguments. Factor them into a struct for consistency and future extensibility.
Comment 1 Antti Koivisto 2021-10-22 03:06:31 PDT 
Created attachment 442140 [details]
Patch
Comment 2 Antti Koivisto 2021-10-22 03:18:28 PDT 
Created attachment 442141 [details]
Patch
Comment 3 Antti Koivisto 2021-10-22 05:36:16 PDT 
Created attachment 442152 [details]
Patch
Comment 4 Antti Koivisto 2021-10-22 07:07:44 PDT 
Created attachment 442161 [details]
Patch
Comment 5 Antoine Quint 2021-10-22 08:27:30 PDT 
Comment on attachment 442161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442161&action=review

> Source/WebCore/style/StyleResolver.h:83
> +struct ResolveContext {

Shouldn't this be called ResolutionContext rather? Resolve is a noun too, but it doesn't mean the same thing, and a noun seems better than a verb here.
Comment 6 Antti Koivisto 2021-10-22 08:28:53 PDT 
> Shouldn't this be called ResolutionContext rather? Resolve is a noun too,
> but it doesn't mean the same thing, and a noun seems better than a verb here.

Good idea
Comment 7 Antti Koivisto 2021-10-22 08:47:11 PDT 
Created attachment 442168 [details]
Patch
Comment 8 EWS 2021-10-22 09:56:42 PDT 
Committed r284693 (243412@main): <https://commits.webkit.org/243412@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442168 [details].
Comment 9 Radar WebKit Bug Importer 2021-10-22 09:57:17 PDT 
<rdar://problem/84553304>
Comment 10 Carlos Alberto Lopez Perez 2021-10-22 11:20:35 PDT 
(In reply to EWS from comment #8)
> Committed r284693 (243412@main): <https://commits.webkit.org/243412@main>
> 
> All reviewed patches have been landed. Closing bug and clearing flags on
> attachment 442168 [details].

This caused the clean build of WebKitGTK to break with a linking error. Reported at bug 232160