Bug 232137 – Factor style resolver context arguments into a struct

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

Style resolver needs context to resolve things correctly. It is currently provided in an ad-hoc manner as a collection of function arguments. Factor them into a struct for consistency and future extensibility.

[Antti Koivisto]

Created attachment 442140 [details]
Patch

[Antti Koivisto]

Created attachment 442141 [details]
Patch

[Antti Koivisto]

Created attachment 442152 [details]
Patch

[Antti Koivisto]

Created attachment 442161 [details]
Patch

[Antoine Quint]

Comment on attachment 442161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442161&action=review

> Source/WebCore/style/StyleResolver.h:83
> +struct ResolveContext {

Shouldn't this be called ResolutionContext rather? Resolve is a noun too, but it doesn't mean the same thing, and a noun seems better than a verb here.

[Antti Koivisto]

> Shouldn't this be called ResolutionContext rather? Resolve is a noun too,
> but it doesn't mean the same thing, and a noun seems better than a verb here.

Good idea

[Antti Koivisto]

Created attachment 442168 [details]
Patch

[EWS]

Committed r284693 (243412@main): <https://commits.webkit.org/243412@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442168 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84553304>

[Carlos Alberto Lopez Perez]

(In reply to EWS from comment #8)
> Committed r284693 (243412@main): <https://commits.webkit.org/243412@main>
> 
> All reviewed patches have been landed. Closing bug and clearing flags on
> attachment 442168 [details].

This caused the clean build of WebKitGTK to break with a linking error. Reported at bug 232160