Bug 232132 - Remove unneeded Heap::m_vm.
Summary: Remove unneeded Heap::m_vm.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-21 22:01 PDT by Mark Lam
Modified: 2021-10-22 00:21 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (15.47 KB, patch)
2021-10-21 22:07 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
[fast-cq] proposed patch. (15.47 KB, patch)
2021-10-21 22:09 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-10-21 22:01:33 PDT 
Heap::vm() already computes the associated VM& using offset math.  This entails subtracting a constant to Heap's this pointer, which is faster than loading from a field.
Comment 1 Mark Lam 2021-10-21 22:07:30 PDT 
Created attachment 442119 [details]
proposed patch.
Comment 2 Mark Lam 2021-10-21 22:09:42 PDT 
Created attachment 442121 [details]
[fast-cq] proposed patch.
Comment 3 Yusuke Suzuki 2021-10-21 22:13:08 PDT 
Comment on attachment 442121 [details]
[fast-cq] proposed patch.

r=me
Comment 4 Mark Lam 2021-10-22 00:18:11 PDT 
Comment on attachment 442121 [details]
[fast-cq] proposed patch.

Thanks for the review.  Landing now.
Comment 5 EWS 2021-10-22 00:20:01 PDT 
Committed r284668 (243388@main): <https://commits.webkit.org/243388@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442121 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-22 00:21:16 PDT 
<rdar://problem/84538981>