Bug 232126 - AX: Keyboard-focusable leaf nodes with labels should be accessible elements on iOS
Summary: AX: Keyboard-focusable leaf nodes with labels should be accessible elements o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-21 18:38 PDT by Tyler Wilcock
Modified: 2021-12-01 11:46 PST (History)
11 users (show)

See Also:

Attachments
WIP for EWS (8.68 KB, patch)
2021-10-21 18:47 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Test only -- do not review or cq+ (3.76 KB, patch)
2021-10-21 19:19 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (11.91 KB, patch)
2021-10-25 09:53 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2021-10-21 18:38:29 PDT 
Keyboard-focusable leaf nodes with labels should be accessible elements on iOS
Comment 1 Radar WebKit Bug Importer 2021-10-21 18:38:39 PDT 
<rdar://problem/84531720>
Comment 2 Tyler Wilcock 2021-10-21 18:47:12 PDT 
Created attachment 442102 [details]
WIP for EWS
Comment 3 Tyler Wilcock 2021-10-21 19:19:35 PDT 
Created attachment 442103 [details]
Test only -- do not review or cq+
Comment 4 Tyler Wilcock 2021-10-25 09:53:28 PDT 
Created attachment 442379 [details]
Patch
Comment 5 EWS 2021-10-25 10:58:08 PDT 
Committed r284796 (243504@main): <https://commits.webkit.org/243504@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442379 [details].
Comment 6 alehm 2021-11-30 10:11:06 PST 
Hi Tyler, do you have any details of when this fix can be released (i.e. an iOS version)?
Comment 7 Tyler Wilcock 2021-11-30 18:14:12 PST 
Really sorry, but I don't know exactly when it'll be included in a release.

Also, just want to point out this comment again in case you missed it:

https://bugs.webkit.org/show_bug.cgi?id=223492#c16

The patch in this bug makes keyboard-focusable leaf nodes with labels accessible elements, but VoiceOver won't read them unless they also have a width and height >= 1px. If that's a problem for your use-case, we can open up a follow-up bug.
Comment 8 alehm 2021-12-01 11:46:18 PST 
Oh, I indeed missed that, so sorry about that. Yeah, our keyboard-focusable leaf nodes will be >= 1px. Thanks!