Bug 232120 – REGRESSION (r284650-284661): [iOS15 Sim] imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html is a text failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Hutchison]

imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html

is a text failure on iOS15 EWS

History: https://results.webkit.org/?suite=layout-tests&test=imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html

Build: https://ews-build.webkit.org/#/builders/68/builds/159

Results: https://ews-build.s3-us-west-2.amazonaws.com/iOS-15-Simulator-WK2-Tests-EWS/r441997-159/results.html

Diff:
--- /Volumes/Data/worker/iOS-15-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms-expected.txt
+++ /Volumes/Data/worker/iOS-15-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms-actual.txt
@@ -1,3 +1,3 @@
 
-FAIL Test that script executes if allowed by proper hash values assert_true: expected true got false
+FAIL Test that script executes if allowed by proper hash values assert_unreached: Should not have triggered a security event Reached unreachable code
 
Unable to locally reproduce the text failure.

[Radar WebKit Bug Importer]

<rdar://problem/84529888>

[Eric Hutchison]

Updated test expectations at https://trac.webkit.org/changeset/284659/webkit

[Alexey Proskuryakov]

Test history shows that this isn't just EWS, but a very recent trunk regression.

> Unable to locally reproduce the text failure.

Which revision were you attempting to reproduce with?

[Ryan Haddad]

LayoutTests/TestExpectations:5154:imported/w3c/web-platform-tests/content-security-policy/script-src/ [ DumpJSConsoleLogInStdErr ]

The flaky expectation added in r284659 is overriding this and causing the test to show up as a consistent failure now.

[Eric Hutchison]

(In reply to Ryan Haddad from comment #4)
> LayoutTests/TestExpectations:5154:imported/w3c/web-platform-tests/content-
> security-policy/script-src/ [ DumpJSConsoleLogInStdErr ]
> 
> The flaky expectation added in r284659 is overriding this and causing the
> test to show up as a consistent failure now.

Add expectation: https://trac.webkit.org/changeset/284708/webkit

[Kate Cheney]

Created attachment 442616 [details]
Patch

[Brent Fulgham]

Comment on attachment 442616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442616&action=review

r=me

> Source/WebCore/page/csp/ContentSecurityPolicy.cpp:374
> +    Vector<ContentSecurityPolicyHash> hashes;

If we might have many hashes, we could preallocate hashes for the size of algorithms, but maybe we only ever have a handful.

> Source/WebCore/page/csp/ContentSecurityPolicy.cpp:376
>          ContentSecurityPolicyHash hash = cryptographicDigestForBytes(algorithm, encodedContent.data(), encodedContent.size());

This could be auto

[Kate Cheney]

(In reply to Brent Fulgham from comment #7)
> Comment on attachment 442616 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442616&action=review
> 
> r=me
> 

Thanks! Going to wait for EWS before landing, in case I missed any failing tests locally.

> > Source/WebCore/page/csp/ContentSecurityPolicy.cpp:374
> > +    Vector<ContentSecurityPolicyHash> hashes;
> 
> If we might have many hashes, we could preallocate hashes for the size of
> algorithms, but maybe we only ever have a handful.
> 

We will only ever have 3 at most because only sha256, sha384, and sha512 are supported. So, probably not too much of an efficiency boost, but I will change it if you think it is important.

> > Source/WebCore/page/csp/ContentSecurityPolicy.cpp:376
> >          ContentSecurityPolicyHash hash = cryptographicDigestForBytes(algorithm, encodedContent.data(), encodedContent.size());
> 
> This could be auto

Will fix.

[Kate Cheney]

Created attachment 442626 [details]
Patch for landing

[EWS]

Committed r284959 (243611@main): <https://commits.webkit.org/243611@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442626 [details].