Bug 23210 – Make it easier for ports to define custom UI for media controls

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Eric Carlson]

It should be easier for ports to define their own media controls UI. Specifically we should not require the CSS to be in a single static variable, and we should assume that hit testing a control element's bounding box is sufficient.

[Eric Carlson]

Created attachment 26566 [details]
proposed patch

[Eric Carlson]

err, I meant to say "we should NOT assume that hit testing a control element's bounding box is
sufficient"

[Eric Seidel (no email)]

Comment on attachment 26566 [details]
proposed patch

I would expect this to be either:
const String& or String.  I'm not sure what const String would do for you.

The preferred webkit style is no else after return:
+    if (renderer() && renderer()->style()->hasAppearance())
+        return theme()->hitTestMediaControlPart(renderer(), absPoint);
+    else
+        return false;

No need for "o" here:
+    virtual bool hitTestMediaControlPart(RenderObject* o, const IntPoint& absPoint);

Otherwise it looks fine.  If you're a commiter, go ahead and fix the nits and land, no need to see another patch.

[Eric Carlson]

Committed revision 39782

[Tor Arne Vestbø]

Created attachment 26665 [details]
Change media controls theming to be overrides instead of complete ruleset

[Tor Arne Vestbø]

Re-opening as I have a patch to how this works. Talked to Eric about this on IRC.

[Tor Arne Vestbø]

Talked to Eric Carlson that is :) 

[Tor Arne Vestbø]

Created attachment 26666 [details]
Updated patch with changelog and #ifdefs in RenderTheme

[Simon Hausmann]

Comment on attachment 26666 [details]
Updated patch with changelog and #ifdefs in RenderTheme

Looks good to me!