Bug 232093 – Two null box iterators from different paths fail to compare equal

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Gabriel Nava Marino]

Two null box iterators from different paths fail to compare equal in BoxIterator::operator==(

[Gabriel Nava Marino]

Per Antti's recommendation, we will compare equal in the case "both box and end get computed to null iterators (atEnd() is true)" as is currently happening in this loop:

        for (auto box = inlineBox->firstLeafBox(), end = inlineBox->endLeafBox(); box != end; box.traverseNextOnLine()) {
            if (!box->isText())
                continue;

[Gabriel Nava Marino]

Created attachment 442047 [details]
Patch

[Gabriel Nava Marino]

(In reply to Gabriel Nava Marino from comment #1)
> Per Antti's recommendation, we will compare equal in the case "both box and
> end get computed to null iterators (atEnd() is true)" as is currently
 as is *not* currently happening in this loop
> happening in this loop:
> 
>         for (auto box = inlineBox->firstLeafBox(), end =
> inlineBox->endLeafBox(); box != end; box.traverseNextOnLine()) {
>             if (!box->isText())
>                 continue;

[EWS]

Committed r284665 (243385@main): <https://commits.webkit.org/243385@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442047 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84535523>