Bug 232091 - [LFC][IFC] Add support for checking leading collapsible whitespace in InlineContentBreaker::processOverflowingContent
Summary: [LFC][IFC] Add support for checking leading collapsible whitespace in InlineC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-21 09:29 PDT by zalan
Modified: 2021-10-22 06:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.77 KB, patch)
2021-10-21 09:39 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.86 KB, patch)
2021-10-21 16:05 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.93 KB, patch)
2021-10-22 06:08 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-10-21 09:29:56 PDT 
ssia
Comment 1 zalan 2021-10-21 09:39:20 PDT 
Created attachment 442043 [details]
Patch
Comment 2 zalan 2021-10-21 16:05:56 PDT 
Created attachment 442079 [details]
Patch
Comment 3 Antti Koivisto 2021-10-22 06:02:43 PDT 
Comment on attachment 442079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442079&action=review

> Source/WebCore/ChangeLog:12
> +
> +        This patch ensures that the leading collapsible whitespace on the continuous run is taken
> +        into account when checking if the otherwise overflowing content may fit the line.
> +        e.g.
> +        <span style="white-space: nowrap">no_wrap </span><span> yes_wrap</span>
> +        The " yes_wrap" content has a collapsible leading whitespace here. 

This could mention that the tests are part of the upcoming patches.
Comment 4 zalan 2021-10-22 06:08:45 PDT 
Created attachment 442156 [details]
Patch
Comment 5 EWS 2021-10-22 06:44:08 PDT 
Committed r284678 (243398@main): <https://commits.webkit.org/243398@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442156 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-22 06:45:15 PDT 
<rdar://problem/84547740>