For linux distributions which do not use systemd, there exists an alternative login deamon, elogind, which is commonly used. elogind is compatible with systemd's journald interface. Renaming the `USE_SYSTEMD` configuration option to `ENABLE_JOURNALD_LOG` and adding the possibility to detect libelogind, would allow such distros to build with logging enabled.
Created attachment 442024 [details] Patch
Created attachment 442026 [details] Patch
Comment on attachment 442026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442026&action=review > w/Source/WTF/wtf/Logger.h:244 > -#if USE(SYSTEMD) > +#if USE(JOURNALD) If you're changing the name of the public build option to ENABLE_JOURNALD_LOG, then also change its usage in the code to ENABLE(JOURNALD_LOG). > w/Source/cmake/OptionsWPE.cmake:240 > SET_AND_EXPOSE_TO_BUILD(USE_JOURNALD TRUE) Then here you would SET_AND_EXPOSE_TO_BUILD(ENABLE_JOURNALD_LOG TRUE)
Created attachment 442031 [details] Patch
(In reply to Michael Catanzaro from comment #3) > Comment on attachment 442026 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442026&action=review > > > w/Source/WTF/wtf/Logger.h:244 > > -#if USE(SYSTEMD) > > +#if USE(JOURNALD) > > If you're changing the name of the public build option to > ENABLE_JOURNALD_LOG, then also change its usage in the code to > ENABLE(JOURNALD_LOG). > > > w/Source/cmake/OptionsWPE.cmake:240 > > SET_AND_EXPOSE_TO_BUILD(USE_JOURNALD TRUE) > > Then here you would SET_AND_EXPOSE_TO_BUILD(ENABLE_JOURNALD_LOG TRUE) Makes sense and should also help tracking the source of the macro. Consequently, I have also renamed all entries of USE(JOURNALD) to ENABLE(JOURNALD_LOG)
Phil, any objections? The patch looks good to me.
Committed r284673 (243393@main): <https://commits.webkit.org/243393@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442031 [details].