Bug 232070 – StreamConnectionWorkQueue::processStreams() has a incorrect protection ref

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kimmo Kinnunen]

`StreamConnectionWorkQueue::processStreams()` has a incorrect protection ref

The `processStreams()` runs in the work queue thread.
It cannot hold the last ref of itself, as that would mean that it would destroy itself in the thread it runs.
This is not possible.

[Kimmo Kinnunen]

Created attachment 441997 [details]
Patch

[Wenson Hsieh]

Comment on attachment 441997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441997&action=review

> Source/WebKit/ChangeLog:12
> +        task, and since `stop()` waits until queue has executed the

In that case, I think we should consider renaming `stop()` to `stopAndWaitForTasksToComplete()`, to make it clear that it must always block on the work queue thread.

[Kimmo Kinnunen]

Created attachment 442134 [details]
Patch for landing

[Kimmo Kinnunen]

(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 441997 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441997&action=review
> 
> > Source/WebKit/ChangeLog:12
> > +        task, and since `stop()` waits until queue has executed the
> 
> In that case, I think we should consider renaming `stop()` to
> `stopAndWaitForTasksToComplete()`, to make it clear that it must always
> block on the work queue thread.

Thanks, added it as stopAndWaitForCompletion to use same naming as Thread

[EWS]

Committed r284681 (243401@main): <https://commits.webkit.org/243401@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442134 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84549004>