Bug 232063 - Minimize WebCore/Header.h includes inside WebCore
Summary: Minimize WebCore/Header.h includes inside WebCore
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-20 17:47 PDT by Don Olmstead
Modified: 2021-10-27 17:48 PDT (History)
8 users (show)

See Also:

Attachments
WIP Patch (3.35 KB, patch)
2021-10-20 17:48 PDT, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-10-20 17:47:38 PDT 
Should be using "Header.h" still unless there's a very very good reason otherwise.
Comment 1 Don Olmstead 2021-10-20 17:48:15 PDT 
Created attachment 441968 [details]
WIP Patch
Comment 2 Alexey Proskuryakov 2021-10-20 21:14:47 PDT 
Comment on attachment 441968 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441968&action=review

> Source/WebCore/platform/ios/WebItemProviderPasteboard.h:-27
> -#import <WebCore/AbstractPasteboard.h>

I do not think that this is right. As WebCore is an implementation detail of WebKit, it should be very easy to promote headers to SPI. And this they should all use framework style includes in this project.
Comment 3 Radar WebKit Bug Importer 2021-10-27 17:48:18 PDT 
<rdar://problem/84735872>