WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
232063
Minimize WebCore/Header.h includes inside WebCore
https://bugs.webkit.org/show_bug.cgi?id=232063
Summary
Minimize WebCore/Header.h includes inside WebCore
Don Olmstead
Reported
2021-10-20 17:47:38 PDT
Should be using "Header.h" still unless there's a very very good reason otherwise.
Attachments
WIP Patch
(3.35 KB, patch)
2021-10-20 17:48 PDT
,
Don Olmstead
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Don Olmstead
Comment 1
2021-10-20 17:48:15 PDT
Created
attachment 441968
[details]
WIP Patch
Alexey Proskuryakov
Comment 2
2021-10-20 21:14:47 PDT
Comment on
attachment 441968
[details]
WIP Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=441968&action=review
> Source/WebCore/platform/ios/WebItemProviderPasteboard.h:-27 > -#import <WebCore/AbstractPasteboard.h>
I do not think that this is right. As WebCore is an implementation detail of WebKit, it should be very easy to promote headers to SPI. And this they should all use framework style includes in this project.
Radar WebKit Bug Importer
Comment 3
2021-10-27 17:48:18 PDT
<
rdar://problem/84735872
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug