Bug 232061 - [WinCairo] Add additional exports for a SHARED WebCore
Summary: [WinCairo] Add additional exports for a SHARED WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks: 232062
  Show dependency tree / graph
 
Reported: 2021-10-20 17:29 PDT by Don Olmstead
Modified: 2023-02-08 22:11 PST (History)
21 users (show)

See Also:

Attachments
Patch (29.26 KB, patch)
2021-10-20 17:39 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-10-20 17:29:31 PDT 
Would like to have the option to do a SHARED WebCore going forward.
Comment 1 Don Olmstead 2021-10-20 17:39:53 PDT 
Created attachment 441966 [details]
Patch
Comment 2 Myles C. Maxfield 2021-10-20 20:42:07 PDT 
What is a SHARED WebCore?
Comment 3 Don Olmstead 2021-10-21 10:59:36 PDT 
(In reply to Myles C. Maxfield from comment #2)
> What is a SHARED WebCore?

SHARED in CMake vernacular for whatever a shared library is on a platform. So .dll for windows, .so for *nix, and a .dylib on OS X.
Comment 4 Myles C. Maxfield 2021-10-21 11:57:21 PDT 
I see. Currently, cmake builds WebCore as a static library?
Comment 5 Don Olmstead 2021-10-21 12:58:29 PDT 
(In reply to Myles C. Maxfield from comment #4)
> I see. Currently, cmake builds WebCore as a static library?

It depends on the port. WinCairo is currently building it as an OBJECT library which is similar to STATIC. Mac ports would need it to build as SHARED.
Comment 6 Fujii Hironori 2023-02-08 22:11:53 PST 
fixed by bug#247944.