Bug 232052 - [JSC][32bit] Re-enable compileEnumeratorGetByVal fast path
Summary: [JSC][32bit] Re-enable compileEnumeratorGetByVal fast path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 230189 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-10-20 15:29 PDT by Mikhail R. Gadelha
Modified: 2021-10-23 12:20 PDT (History)
9 users (show)

See Also:

Attachments
Patch (24.58 KB, patch)
2021-10-20 15:33 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Patch (39.47 KB, patch)
2021-10-21 06:18 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Patch (46.42 KB, patch)
2021-10-21 07:11 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Patch (38.41 KB, patch)
2021-10-22 06:21 PDT, Mikhail R. Gadelha 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail R. Gadelha 2021-10-20 15:29:18 PDT 
[JSC][32bit] Re-enable compileEnumeratorGetByVal fast path
Comment 1 Mikhail R. Gadelha 2021-10-20 15:33:13 PDT 
Created attachment 441949 [details]
Patch
Comment 2 Mikhail R. Gadelha 2021-10-21 06:18:27 PDT 
Created attachment 442013 [details]
Patch
Comment 3 Mikhail R. Gadelha 2021-10-21 07:11:05 PDT 
Created attachment 442016 [details]
Patch
Comment 4 Yusuke Suzuki 2021-10-21 16:05:09 PDT 
Comment on attachment 442016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442016&action=review

r- since the new code is not great compared to the current 64bit implementation.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:15891
> +            flushRegisters();
> +

This is regressing 64bit implementation from the current one.
Can you remove it?
If this is necessary for 32bit implementation, so please keep 32bit and 64bit implementations separated.
Comment 5 Mikhail R. Gadelha 2021-10-22 06:21:35 PDT 
Created attachment 442158 [details]
Patch
Comment 6 Yusuke Suzuki 2021-10-22 11:16:14 PDT 
Comment on attachment 442158 [details]
Patch

r=me
Comment 7 EWS 2021-10-22 11:31:57 PDT 
Committed r284700 (243417@main): <https://commits.webkit.org/243417@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442158 [details].
Comment 8 Radar WebKit Bug Importer 2021-10-22 11:32:17 PDT 
<rdar://problem/84557181>
Comment 9 Xan Lopez 2021-10-23 12:20:49 PDT 
*** Bug 230189 has been marked as a duplicate of this bug. ***