[JSC] ArithAbs should care about INT32_MIN
Created attachment 441946 [details] Patch
<rdar://problem/84338648>
Comment on attachment 441946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441946&action=review r=me > Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1395 > + // If ArithAbs cares overflow, then INT32_MIN input will cause OSR exit. "cares about" sounds better. > Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1402 > + // If ArithAbs does not care overflow, it can return INT32_MIN if the input is INT32_MIN. "... care about overflow" sounds better.
Comment on attachment 441946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441946&action=review >> Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1395 >> + // If ArithAbs cares overflow, then INT32_MIN input will cause OSR exit. > > "cares about" sounds better. Sounds good! >> Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1402 >> + // If ArithAbs does not care overflow, it can return INT32_MIN if the input is INT32_MIN. > > "... care about overflow" sounds better. Nice, fixed.
Committed r284585 (243320@main): <https://commits.webkit.org/243320@main>