RESOLVED FIXED 232051
[JSC] ArithAbs should care about INT32_MIN 
https://bugs.webkit.org/show_bug.cgi?id=232051
Summary [JSC] ArithAbs should care about INT32_MIN
Yusuke Suzuki
Reported 2021-10-20 15:12:51 PDT
[JSC] ArithAbs should care about INT32_MIN
Attachments
Patch (2.42 KB, patch)
2021-10-20 15:14 PDT, Yusuke Suzuki 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-10-20 15:14:03 PDT
Created attachment 441946 [details] Patch
Yusuke Suzuki
Comment 2 2021-10-20 15:14:07 PDT
<rdar://problem/84338648>
Michael Saboff
Comment 3 2021-10-20 15:20:40 PDT
Comment on attachment 441946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441946&action=review r=me > Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1395 > + // If ArithAbs cares overflow, then INT32_MIN input will cause OSR exit. "cares about" sounds better. > Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1402 > + // If ArithAbs does not care overflow, it can return INT32_MIN if the input is INT32_MIN. "... care about overflow" sounds better.
Yusuke Suzuki
Comment 4 2021-10-20 15:58:35 PDT
Comment on attachment 441946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441946&action=review >> Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1395 >> + // If ArithAbs cares overflow, then INT32_MIN input will cause OSR exit. > > "cares about" sounds better. Sounds good! >> Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1402 >> + // If ArithAbs does not care overflow, it can return INT32_MIN if the input is INT32_MIN. > > "... care about overflow" sounds better. Nice, fixed.
Yusuke Suzuki
Comment 5 2021-10-20 17:00:39 PDT
Committed r284585 (243320@main): <https://commits.webkit.org/243320@main>
Note You need to log in before you can comment on or make changes to this bug.