Bug 23205 - Immediate int should be stored in low word of JSValuePtr on x86-64.
Summary: Immediate int should be stored in low word of JSValuePtr on x86-64.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2009-01-08 21:23 PST by Gavin Barraclough
Modified: 2009-01-09 00:11 PST (History)
0 users

See Also:

The patch (53.19 KB, patch)
2009-01-08 21:24 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
The patch (53.64 KB, patch)
2009-01-08 21:30 PST, Gavin Barraclough
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2009-01-08 21:23:27 PST
This will simplify arithmetic, by removing the need to de-tag values.
Comment 1 Gavin Barraclough 2009-01-08 21:24:30 PST
Created attachment 26554 [details]
The patch
Comment 2 Gavin Barraclough 2009-01-08 21:30:12 PST
Created attachment 26555 [details]
The patch
Comment 3 Sam Weinig 2009-01-08 21:48:08 PST
Comment on attachment 26555 [details]
The patch

Awesome!  r=me
Comment 4 Gavin Barraclough 2009-01-09 00:11:24 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/assembler/MacroAssembler.h
Sending        JavaScriptCore/assembler/X86Assembler.h
Sending        JavaScriptCore/jit/JIT.cpp
Sending        JavaScriptCore/jit/JIT.h
Sending        JavaScriptCore/jit/JITArithmetic.cpp
Sending        JavaScriptCore/jit/JITCall.cpp
Sending        JavaScriptCore/jit/JITInlineMethods.h
Sending        JavaScriptCore/jit/JITPropertyAccess.cpp
Sending        JavaScriptCore/runtime/JSImmediate.h
Sending        JavaScriptCore/wtf/Platform.h
Transmitting file data ...........
Committed revision 39738.