WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
232044
[WebRTC] Simplify libwebtc Xcode project
https://bugs.webkit.org/show_bug.cgi?id=232044
Summary
[WebRTC] Simplify libwebtc Xcode project
David Kilzer (:ddkilzer)
Reported
2021-10-20 14:20:01 PDT
Simplify libwebtc Xcode project. This will fix: - Install webm headers consistently. - Remove some duplicate references to C++ source files. - Remove "Recovered References" folder (for files that don't exist at their path anymore). <
rdar://problem/82743710
>
Attachments
Patch v1
(28.19 KB, patch)
2021-10-20 16:58 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2021-10-20 16:58:43 PDT
Created
attachment 441956
[details]
Patch v1
youenn fablet
Comment 2
2021-10-21 01:42:02 PDT
Maybe we should create a separate libwebm Xcode project in the future.
David Kilzer (:ddkilzer)
Comment 3
2021-10-21 03:12:58 PDT
(In reply to youenn fablet from
comment #2
)
> Maybe we should create a separate libwebm Xcode project in the future.
I’m not sure it would be worth the extra work to be honest. I suspect Xcode is faster opening one project with 7 targets vs. one project with 6 subprojects. Thanks for the review!
David Kilzer (:ddkilzer)
Comment 4
2021-10-21 03:14:06 PDT
Comment on
attachment 441956
[details]
Patch v1 Marking cq+ since this patch needed building, not testing.
EWS
Comment 5
2021-10-21 03:50:35 PDT
Committed
r284599
(
243328@main
): <
https://commits.webkit.org/243328@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 441956
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug