Bug 232035 - run-webkit-tests --ios-simulator --print-expectations fails
Summary: run-webkit-tests --ios-simulator --print-expectations fails
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2021-10-20 12:44 PDT by Simon Fraser (smfr)
Modified: 2021-10-21 09:18 PDT (History)
6 users (show)

See Also:

Patch (2.09 KB, patch)
2021-10-20 12:53 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-20 12:44:31 PDT
Error printing expectations: <webkitpy.xcode.device_type.DeviceType object at 0x101caf7d0>
Comment 1 Simon Fraser (smfr) 2021-10-20 12:46:37 PDT
iOS simulator port has DEFAULT_DEVICE_TYPES.

_collect_tests gets passed a device_type_list with this list, but ignores it and calls self._port.supported_device_types()
Comment 2 Simon Fraser (smfr) 2021-10-20 12:50:45 PDT
... and the device types don't match, so using device_type_list[0] as a key later throws.
Comment 3 Simon Fraser (smfr) 2021-10-20 12:53:31 PDT
Created attachment 441922 [details]
Comment 4 EWS 2021-10-21 09:17:17 PDT
Committed r284605 (243334@main): <https://commits.webkit.org/243334@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441922 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-21 09:18:17 PDT