Bug 232020 - CSSPropertyZoom needs wrapper that ensures it's always blended into a positive value.
Summary: CSSPropertyZoom needs wrapper that ensures it's always blended into a positiv...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
Keywords: InRadar
Depends on:
Reported: 2021-10-20 10:25 PDT by Gabriel Nava Marino
Modified: 2021-10-21 05:40 PDT (History)
5 users (show)

See Also:

Patch (12.67 KB, patch)
2021-10-21 02:55 PDT, Antoine Quint
koivisto: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Nava Marino 2021-10-20 10:25:01 PDT
It was recommended to consider "NonNegativeFloatPropertyWrapper as it could be refactored it to support various flags, for instance one for non-negative values, and one for strictly positive values, like we need for zoom"
Comment 1 Gabriel Nava Marino 2021-10-20 10:56:06 PDT
Comment 2 Radar WebKit Bug Importer 2021-10-20 10:56:57 PDT
Comment 3 Antoine Quint 2021-10-21 02:55:30 PDT
Created attachment 442001 [details]
Comment 4 Antti Koivisto 2021-10-21 02:58:35 PDT
Comment on attachment 442001 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=442001&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:2140
> +    enum class ValueRange : uint8_t {
> +        All,
> +        NonNegative,
> +        Positive
> +    };

Comment 5 EWS 2021-10-21 04:53:38 PDT
Tools/Scripts/svn-apply failed to apply attachment 442001 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Antoine Quint 2021-10-21 05:40:19 PDT
Committed r284602 (243331@main): <https://commits.webkit.org/243331@main>