Bug 231996 - *IsSane API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering
Summary: *IsSane API's could take in the Structure's we're consulting, or they can be ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-19 17:21 PDT by Saam Barati
Modified: 2021-10-21 11:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (16.99 KB, patch)
2021-10-20 21:17 PDT, Yusuke Suzuki
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-10-19 17:21:58 PDT
...
Comment 1 Yusuke Suzuki 2021-10-20 21:17:59 PDT
Created attachment 441981 [details]
Patch
Comment 2 Mark Lam 2021-10-20 21:24:48 PDT
Comment on attachment 441981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441981&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        *IsSain API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering

drive by comment: Can you fix the typo in the title "isSain" => "isSane"?  Same for bugzilla.
Comment 3 Yusuke Suzuki 2021-10-20 23:27:03 PDT
Comment on attachment 441981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441981&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        *IsSain API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering
> 
> drive by comment: Can you fix the typo in the title "isSain" => "isSane"?  Same for bugzilla.

Thanks! Fixed.
Comment 4 Yusuke Suzuki 2021-10-20 23:28:14 PDT
Committed r284590 (243323@main): <https://commits.webkit.org/243323@main>
Comment 5 Radar WebKit Bug Importer 2021-10-20 23:29:16 PDT
<rdar://problem/84494690>
Comment 6 Saam Barati 2021-10-21 11:53:22 PDT
Comment on attachment 441981 [details]
Patch

Nice!