Bug 231973 - Address post-landing feedback to wasm exceptions
Summary: Address post-landing feedback to wasm exceptions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-19 12:02 PDT by Tadeu Zagallo
Modified: 2021-10-19 17:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (25.49 KB, patch)
2021-10-19 12:52 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch for landing (25.49 KB, patch)
2021-10-19 17:08 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2021-10-19 12:02:03 PDT 
...
Comment 1 Tadeu Zagallo 2021-10-19 12:52:21 PDT 
Created attachment 441774 [details]
Patch
Comment 2 Saam Barati 2021-10-19 14:59:24 PDT 
Comment on attachment 441774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441774&action=review

r=me

> Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:1176
> +    // We have to materialize the arguments here since it might included constants or

included => include

> Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:1178
> +    // in stack. The reason we don't call materializeConstantsAndLocals here is that

in stack => in the stack
Comment 3 Tadeu Zagallo 2021-10-19 17:08:38 PDT 
Created attachment 441818 [details]
Patch for landing
Comment 4 EWS 2021-10-19 17:40:26 PDT 
Committed r284513 (243257@main): <https://commits.webkit.org/243257@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441818 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-19 17:41:26 PDT 
<rdar://problem/84441842>