Bug 231959 – [ iOS ] imported/w3c/web-platform-tests/html/canvas/element/manual tests, fast/canvas/canvas-createPattern-video-modify.html and media/video-canvas-createPattern.html are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-video.html
imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html

Are failing on iOS 15.

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fcanvas%2Felement%2Fmanual%2Fwide-gamut-canvas%2Fcanvas-display-p3-drawImage-ImageBitmap-video.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fcanvas%2Felement%2Fmanual%2Fwide-gamut-canvas%2Fcanvas-display-p3-drawImage-video.html

Those test are marked to fail in iOS-14 but marked to pass in ios here https://trac.webkit.org/changeset/284439/webkit.

Result page: https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/r284442%20(226)/results.html#

[Radar WebKit Bug Importer]

<rdar://problem/84417651>

Marked expectations fail in iOS-wk2 so that the tests won't show up as failure https://trac.webkit.org/changeset/284457/webkit

It looks like media/video-canvas-createPattern.html modified here also started failing  on iPad.

History: https://results.webkit.org/?suite=layout-tests&test=media%2Fvideo-canvas-createPattern.html

Result page: https://build.webkit.org/results/Apple-iPadOS-15-Simulator-Release-WK2-Tests/r284441%20(176)/results.html#

Diff:

--- /Volumes/Data/worker/ipados-simulator-15-release-tests-wk2/build/layout-test-results/media/video-canvas-createPattern-expected.txt
+++ /Volumes/Data/worker/ipados-simulator-15-release-tests-wk2/build/layout-test-results/media/video-canvas-createPattern-actual.txt
@@ -1,56 +1,56 @@
 
 EVENT(canplaythrough)
 EVENT(seeked)
-Saw close enough to (200, 200, 0) at (40, 165) OK
-Saw close enough to (200, 200, 0) at (355, 165) OK
-Saw close enough to (200, 200, 0) at (40, 403) OK
-Saw close enough to (200, 200, 0) at (355, 403) OK
-Saw close enough to (57, 202, 203) at (56, 165) OK
-Saw close enough to (57, 202, 203) at (371, 165) OK
-Saw close enough to (57, 202, 203) at (56, 403) OK
-Saw close enough to (57, 202, 203) at (371, 403) OK
-Saw close enough to (53, 203, 9) at (73, 165) OK
-Saw close enough to (53, 203, 9) at (388, 165) OK
-Saw close enough to (53, 203, 9) at (73, 403) OK
-Saw close enough to (53, 203, 9) at (388, 403) OK
+Expected (200, 200, 0) at (40, 165) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (355, 165) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (40, 403) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (355, 403) but saw (194, 194, 14) FAIL
+Expected (57, 202, 203) at (56, 165) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (371, 165) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (56, 403) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (371, 403) but saw (17, 197, 196) FAIL
+Expected (53, 203, 9) at (73, 165) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (388, 165) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (73, 403) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (388, 403) but saw (19, 199, 18) FAIL
 EVENT(seeked)
-Saw close enough to (200, 200, 0) at (40, 165) OK
-Saw close enough to (200, 200, 0) at (355, 165) OK
-Saw close enough to (200, 200, 0) at (40, 403) OK
-Saw close enough to (200, 200, 0) at (355, 403) OK
-Saw close enough to (57, 202, 203) at (56, 165) OK
-Saw close enough to (57, 202, 203) at (371, 165) OK
-Saw close enough to (57, 202, 203) at (56, 403) OK
-Saw close enough to (57, 202, 203) at (371, 403) OK
-Saw close enough to (53, 203, 9) at (73, 165) OK
-Saw close enough to (53, 203, 9) at (388, 165) OK
-Saw close enough to (53, 203, 9) at (73, 403) OK
-Saw close enough to (53, 203, 9) at (388, 403) OK
+Expected (200, 200, 0) at (40, 165) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (355, 165) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (40, 403) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (355, 403) but saw (194, 194, 14) FAIL
+Expected (57, 202, 203) at (56, 165) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (371, 165) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (56, 403) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (371, 403) but saw (17, 197, 196) FAIL
+Expected (53, 203, 9) at (73, 165) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (388, 165) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (73, 403) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (388, 403) but saw (19, 199, 18) FAIL
 EVENT(seeked)
-Saw close enough to (200, 200, 0) at (40, 165) OK
-Saw close enough to (200, 200, 0) at (355, 165) OK
-Saw close enough to (200, 200, 0) at (40, 403) OK
-Saw close enough to (200, 200, 0) at (355, 403) OK
-Saw close enough to (57, 202, 203) at (56, 165) OK
-Saw close enough to (57, 202, 203) at (371, 165) OK
-Saw close enough to (57, 202, 203) at (56, 403) OK
-Saw close enough to (57, 202, 203) at (371, 403) OK
-Saw close enough to (53, 203, 9) at (73, 165) OK
-Saw close enough to (53, 203, 9) at (388, 165) OK
-Saw close enough to (53, 203, 9) at (73, 403) OK
-Saw close enough to (53, 203, 9) at (388, 403) OK
+Expected (200, 200, 0) at (40, 165) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (355, 165) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (40, 403) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (355, 403) but saw (194, 194, 14) FAIL
+Expected (57, 202, 203) at (56, 165) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (371, 165) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (56, 403) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (371, 403) but saw (17, 197, 196) FAIL
+Expected (53, 203, 9) at (73, 165) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (388, 165) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (73, 403) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (388, 403) but saw (19, 199, 18) FAIL
 EVENT(seeked)
-Saw close enough to (200, 200, 0) at (40, 165) OK
-Saw close enough to (200, 200, 0) at (355, 165) OK
-Saw close enough to (200, 200, 0) at (40, 403) OK
-Saw close enough to (200, 200, 0) at (355, 403) OK
-Saw close enough to (57, 202, 203) at (56, 165) OK
-Saw close enough to (57, 202, 203) at (371, 165) OK
-Saw close enough to (57, 202, 203) at (56, 403) OK
-Saw close enough to (57, 202, 203) at (371, 403) OK
-Saw close enough to (53, 203, 9) at (73, 165) OK
-Saw close enough to (53, 203, 9) at (388, 165) OK
-Saw close enough to (53, 203, 9) at (73, 403) OK
-Saw close enough to (53, 203, 9) at (388, 403) OK
+Expected (200, 200, 0) at (40, 165) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (355, 165) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (40, 403) but saw (194, 194, 14) FAIL
+Expected (200, 200, 0) at (355, 403) but saw (194, 194, 14) FAIL
+Expected (57, 202, 203) at (56, 165) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (371, 165) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (56, 403) but saw (17, 197, 196) FAIL
+Expected (57, 202, 203) at (371, 403) but saw (17, 197, 196) FAIL
+Expected (53, 203, 9) at (73, 165) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (388, 165) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (73, 403) but saw (19, 199, 18) FAIL
+Expected (53, 203, 9) at (388, 403) but saw (19, 199, 18) FAIL
 END OF TEST

imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html
imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html
fast/canvas/canvas-createPattern-video-modify.html

Are also failing.

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fcanvas%2Fcanvas-createPattern-video-modify.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fcanvas%2Felement%2Fmanual%2Fimagebitmap%2FcreateImageBitmap-drawImage.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fcanvas%2Felement%2Fmanual%2Fimagebitmap%2FcreateImageBitmap-flipY.html

Marked test expectations https://trac.webkit.org/changeset/284468/webkit

[Cameron McCormack (:heycam)]

I think the iOS failures are all simulator-only failures.  Testing on iOS 15 locally these tests are passing.

Removed [ Release ] from the test expectations https://trac.webkit.org/changeset/284546/webkit

[Cameron McCormack (:heycam)]

There are two separate issues in the failures marked in this bug.  One is the simulator-only failures, and another is that the tolerance of a couple of WPTs needs to be bumped up.  I will do the WPT change here, and make bug 232090 be the one to track the simulator-only failures.

[Cameron McCormack (:heycam)]

Created attachment 442231 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Cameron McCormack (:heycam)]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/31360

[Cameron McCormack (:heycam)]

Created attachment 442236 [details]
Path for EWS

[Cameron McCormack (:heycam)]

Created attachment 442237 [details]
Patch for EWS

[Cameron McCormack (:heycam)]

Created attachment 442248 [details]
Patch

[EWS]

Committed r284752 (243461@main): <https://commits.webkit.org/243461@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442248 [details].

[Cameron McCormack (:heycam)]

Upstreaming WPT changes: https://github.com/web-platform-tests/wpt/pull/34977