WebKit Objective-C classes should use weak delegates. Found by doing a search for delegate properties using `assign` in WebKit: $ find Source/WebKit -name \*.h -exec grep -l 'assign.*delegate' {} \; Note that 3 out of the 4 fixes are just documenting that the `_delegate` instance variable is already held using WeakObjCPtr<>. The fourth change actually makes the `delegate` property weak.
<rdar://problem/84416233>
Created attachment 441730 [details] Patch v1
Created attachment 441753 [details] Patch v2 (fix typo in title)
Comment on attachment 441753 [details] Patch v2 (fix typo in title) r=me
Comment on attachment 441753 [details] Patch v2 (fix typo in title) Marking cq+ because I'm not sure if the ios bot will ever "fail" to allow a retry, and the ios-wk2 and api-ios bots are 8-24 hours behind. In the "worst case", this patch would change a flakey crashing test to a flakey failing test, so only test expectations would need to be updated (and maybe a new bug filed for the non-crashing flakiness).
Committed r284558 (243300@main): <https://commits.webkit.org/243300@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441753 [details].