Bug 231955 - Improve intrinsic aspect ratio detection
Summary: Improve intrinsic aspect ratio detection
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-19 08:23 PDT by Sergio Villar Senin
Modified: 2021-10-26 08:24 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2021-10-19 08:23:15 PDT 
The current implementation of RenderObject::hasIntrinsicAspectRatio() performs a very basic test to check whether a renderer has intrinsic aspect ratio. It does not cover however the cases of many SVGs which have intrinsic aspect ratios but no intrinsic dimensions.

We should consider make it virtual returning false by default. Then RenderReplaced will overwrite it with the current implementation plus a call to
computeIntrinsicRatioInformation() that will tell us for sure whether or not we have an intrinsic aspect ratio.
Comment 1 Radar WebKit Bug Importer 2021-10-26 08:24:15 PDT 
<rdar://problem/84664281>