Bug 231940 - FunctionDispatcher should not be RefCounted
Summary: FunctionDispatcher should not be RefCounted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 238863
  Show dependency treegraph
 
Reported: 2021-10-19 00:10 PDT by Kimmo Kinnunen
Modified: 2022-04-12 02:45 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.82 KB, patch)
2022-04-06 04:30 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (5.51 KB, patch)
2022-04-06 12:00 PDT, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.40 KB, patch)
2022-04-06 12:33 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (5.42 KB, patch)
2022-04-06 12:40 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (5.42 KB, patch)
2022-04-06 22:40 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
[fast-cq] For landing (5.44 KB, patch)
2022-04-12 02:41 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-10-19 00:10:09 PDT
FunctionDispatcher should not be RefCounted.
There's nothing inherently refcounted about being recipient of task submissions.

FunctionDispatcher being RefCounted lead to fix bug 231897 using this as the solution, where the original bug was bug 231897
Comment 1 Kimmo Kinnunen 2021-10-19 00:12:08 PDT
.. where the original bug was 231939
Comment 2 Radar WebKit Bug Importer 2021-10-26 00:11:18 PDT
<rdar://problem/84650931>
Comment 3 Kimmo Kinnunen 2022-04-06 04:30:20 PDT
Created attachment 456808 [details]
Patch
Comment 4 Kimmo Kinnunen 2022-04-06 12:00:21 PDT
Created attachment 456844 [details]
Patch
Comment 5 Kimmo Kinnunen 2022-04-06 12:33:58 PDT
Created attachment 456847 [details]
Patch
Comment 6 Chris Dumez 2022-04-06 12:37:07 PDT
Comment on attachment 456847 [details]
Patch

r=me
Comment 7 Kimmo Kinnunen 2022-04-06 12:40:08 PDT
Created attachment 456851 [details]
Patch
Comment 8 Kimmo Kinnunen 2022-04-06 12:50:14 PDT
Comment on attachment 456851 [details]
Patch

Thanks! (removing r?, will upload for landing tomorrow)
Comment 9 Kimmo Kinnunen 2022-04-06 22:40:00 PDT
Created attachment 456891 [details]
Patch
Comment 10 EWS 2022-04-11 05:58:06 PDT
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Comment 11 Kimmo Kinnunen 2022-04-12 02:41:45 PDT
Created attachment 457320 [details]
[fast-cq] For landing
Comment 12 EWS 2022-04-12 02:45:05 PDT
Committed r292768 (249552@main): <https://commits.webkit.org/249552@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457320 [details].