Bug 231890 - Close peer connection sockets when entering page cache
Summary: Close peer connection sockets when entering page cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-18 02:41 PDT by youenn fablet
Modified: 2021-10-19 04:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.65 KB, patch)
2021-10-18 02:49 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (6.13 KB, patch)
2021-10-18 04:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (5.45 KB, patch)
2021-10-19 01:00 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-10-18 02:41:27 PDT 
Close peer connection sockets when entering page cache
Comment 1 youenn fablet 2021-10-18 02:49:03 PDT 
Created attachment 441577 [details]
Patch
Comment 2 youenn fablet 2021-10-18 04:53:55 PDT 
Created attachment 441586 [details]
Patch
Comment 3 Eric Carlson 2021-10-18 08:49:02 PDT 
Comment on attachment 441586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441586&action=review

> LayoutTests/webrtc/datachannel/datachannel-page-cache-send.html:37
> +    waitForConnectionState(pc1.connectionState, "disconnected");

Should this be `await waitForConnectionState(pc1.connectionState, "disconnected")` ?
Comment 4 youenn fablet 2021-10-19 01:00:16 PDT 
Created attachment 441697 [details]
Patch for landing
Comment 5 EWS 2021-10-19 04:03:22 PDT 
Committed r284442 (243204@main): <https://commits.webkit.org/243204@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441697 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-19 04:04:17 PDT 
<rdar://problem/84409480>