Bug 231886 - WebM with invalid size should fail to load with error
Summary: WebM with invalid size should fail to load with error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-18 01:25 PDT by Jean-Yves Avenard [:jya]
Modified: 2021-10-18 20:52 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.52 KB, patch)
2021-10-18 16:17 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (7.45 KB, patch)
2021-10-18 16:18 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (5.30 KB, patch)
2021-10-18 17:28 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-10-18 01:25:11 PDT
WebM with invalid size should fail to load with error
Comment 1 Jean-Yves Avenard [:jya] 2021-10-18 01:27:04 PDT
rdar://77969801
Comment 2 Jean-Yves Avenard [:jya] 2021-10-18 16:17:01 PDT
Created attachment 441653 [details]
Patch
Comment 3 Jean-Yves Avenard [:jya] 2021-10-18 16:18:56 PDT
Created attachment 441654 [details]
Patch
Comment 4 Jer Noble 2021-10-18 16:35:10 PDT
Comment on attachment 441654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441654&action=review

> LayoutTests/platform/mac/TestExpectations:2097
> +[ BigSur+ ] media/media-webm-invalid-check.html [ Pass ]

Ironically, the way you wrote the test means it should pass on all ports; ports that don't support .webm files will just error out (correctly).
Comment 5 Jean-Yves Avenard [:jya] 2021-10-18 17:28:06 PDT
Created attachment 441663 [details]
Patch

Enable on all platform seeing that it should elegantly fail everywhere
Comment 6 EWS 2021-10-18 20:52:02 PDT
Committed r284434 (243196@main): <https://commits.webkit.org/243196@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441663 [details].