WebKit::GPUConnectionToWebProcess::setTCCIdentity() leaks a tcc_identity_t. See Bug 231621, Comment #24 from Alex Christensen: > Comment on attachment 441298 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441298&action=review > > > Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm:81 > > + identity = tcc_identity_create(TCC_IDENTITY_CODE_BUNDLE_ID, [bundleProxy.bundleIdentifier UTF8String]); > > tcc_identity_create is annotated with OS_OBJECT_RETURNS_RETAINED, which > means this is probably a memory leak. It should probably be auto identity = > adoptOSObject(tcc_identity_create(...)); which means my build fix of calling > tcc_identity_t will probably also need to be changed to OS_OBJECT_DECL if > OS_OBJECT_USE_OBJC is defined.
<rdar://problem/84350854>
I have a potential fix.
Waiting for Bug 231621 Attachment #441550 [details] to land first.
Created attachment 441556 [details] Patch v1
Comment on attachment 441556 [details] Patch v1 Thanks Chris!
Committed r284373 (243158@main): <https://commits.webkit.org/243158@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441556 [details].