Bug 231881 - overriding RTCVideoDecoderH264/265 color space attachments not always done
Summary: overriding RTCVideoDecoderH264/265 color space attachments not always done
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-17 14:33 PDT by Cameron McCormack (:heycam)
Modified: 2021-10-18 20:43 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.72 KB, patch)
2021-10-17 14:35 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-10-17 14:33:29 PDT 
I found that in some configurations, e.g. builds on Catalina, the "ColorInfoGuessedBy" attachment is not placed on CVPixelBuffers we get from the VTDecompressionSession, but the guessed, incorrect color space attachments are still there. Since we are currently only supporting sRGB color space video streams in WebRTC, we shouldn't check for "ColorInfoGuessedBy", and instead always override the attachments.
Comment 1 Radar WebKit Bug Importer 2021-10-17 14:33:56 PDT 
<rdar://problem/84350707>
Comment 2 Cameron McCormack (:heycam) 2021-10-17 14:35:45 PDT 
Created attachment 441551 [details]
Patch
Comment 3 EWS 2021-10-18 20:43:23 PDT 
Committed r284433 (243195@main): <https://commits.webkit.org/243195@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441551 [details].