There are many functions in AnimationBase (like isNew() and postactive()) which tell you which state or states the state machine is in. But they are really confusing, both in how they are named and what they actually mean. These should all be cleaned up
Also willNeedService() needs a better name.
Also: In Animation: bool direction() const { return m_direction; } This needs to have an enum. int iterationCount() const { return m_iterationCount; } This needs a constant for the magic "-1" value.
*** Bug 23513 has been marked as a duplicate of this bug. ***
Created attachment 27617 [details] Patch to clean up Animation
Created attachment 27620 [details] Same patch with no license changes.
Comment on attachment 27620 [details] Same patch with no license changes. r=me
Comment on attachment 27620 [details] Same patch with no license changes. Landed: Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/css/CSSComputedStyleDeclaration.cpp M WebCore/platform/animation/Animation.cpp M WebCore/platform/animation/Animation.h M WebCore/platform/graphics/mac/GraphicsLayerCA.mm Committed r40923
Closing bug as it has been committed to the archive.
There's more cleanup to do (specifically, willGetService()).
Comment on attachment 27620 [details] Same patch with no license changes. Historically we've tried for one-bug-per-change. But if you'd like to leave this open, we should at least clear the review flag to remove it from the commit queue. (Eventually we should just fix the commit queue query).
I think all the cleanup landed. I can't find any trace of the old confusing names.