WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23187
[QT] in ChromeClientQt::repaint, view should be updated with the intersected rect, not whole windowRect
https://bugs.webkit.org/show_bug.cgi?id=23187
Summary
[QT] in ChromeClientQt::repaint, view should be updated with the intersected ...
Yongjun Zhang
Reported
2009-01-08 10:03:27 PST
In ChromeClientQt::repaint, view should be updated with the intersected rect, not the whole windowRect; This generally is not a problem for normal viewport setup where viewport size is the same as the qwebview widget size. However, if we set the viewport size smaller than qwebkit widget, we will see unwanted painting outside the viewport.
Attachments
use intersected rect to update the view.
(1.18 KB, patch)
2009-01-08 10:06 PST
,
Yongjun Zhang
hausmann
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yongjun Zhang
Comment 1
2009-01-08 10:06:50 PST
Created
attachment 26525
[details]
use intersected rect to update the view.
Simon Hausmann
Comment 2
2009-01-13 12:42:57 PST
Comment on
attachment 26525
[details]
use intersected rect to update the view. Looks good to me, nice catch! I'll paste the description from the bug into the ChangeLog when landing to make it a bit clearer in the ChangeLog what your fix does.
Simon Hausmann
Comment 3
2009-01-13 12:44:23 PST
Landed in
r39874
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug