Bug 231865 - Share stacking context code between RenderLayer & StyleAdjuster
Summary: Share stacking context code between RenderLayer & StyleAdjuster
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-16 11:21 PDT by Tim Nguyen (:ntim)
Modified: 2021-10-16 15:52 PDT (History)
11 users (show)

See Also:

Attachments
Patch (9.96 KB, patch)
2021-10-16 11:31 PDT, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (9.96 KB, patch)
2021-10-16 11:42 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (10.14 KB, patch)
2021-10-16 12:11 PDT, Tim Nguyen (:ntim) 		simon.fraser: review-
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-10-16 11:21:34 PDT 
Situations where CSS should create stacking contexts are written in 3 different places: RenderLayer, StyleAdjuster, WillChangeData

Let's introduce a single method in RenderStyle that RenderLayer & StyleAdjuster can both consult.
Comment 1 Radar WebKit Bug Importer 2021-10-16 11:21:44 PDT 
<rdar://problem/84334466>
Comment 2 Tim Nguyen (:ntim) 2021-10-16 11:31:07 PDT 
Created attachment 441497 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2021-10-16 11:42:06 PDT 
Created attachment 441498 [details]
Patch
Comment 4 Simon Fraser (smfr) 2021-10-16 11:46:34 PDT 
Comment on attachment 441498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441498&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:2790
> +        || hasTransformRelatedProperty()

I think this is a behavior change because renderer.hasTransformRelatedProperty() is not always equivalent to style.hasTransformRelatedProperty() since transforms don't apply to non-atomic lines.
Comment 5 Tim Nguyen (:ntim) 2021-10-16 12:11:33 PDT 
Created attachment 441499 [details]
Patch
Comment 6 Simon Fraser (smfr) 2021-10-16 15:52:44 PDT 
Comment on attachment 441499 [details]
Patch

Test failures show this isn't right.