Bug 231858 - Use inline iterator for SVG reverse BiDI reordering
Summary: Use inline iterator for SVG reverse BiDI reordering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-15 23:15 PDT by Antti Koivisto
Modified: 2021-10-19 18:44 PDT (History)
18 users (show)

See Also:

Attachments
Patch (9.18 KB, patch)
2021-10-15 23:19 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (14.65 KB, patch)
2021-10-16 00:27 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-10-15 23:15:01 PDT 
it doesn't need to be generic.
Comment 1 Antti Koivisto 2021-10-15 23:19:27 PDT 
Created attachment 441478 [details]
Patch
Comment 2 Antti Koivisto 2021-10-16 00:27:16 PDT 
Created attachment 441480 [details]
Patch
Comment 3 EWS 2021-10-16 05:39:44 PDT 
Committed r284315 (243111@main): <https://commits.webkit.org/243111@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441480 [details].
Comment 4 Radar WebKit Bug Importer 2021-10-16 05:40:16 PDT 
<rdar://problem/84331836>
Comment 5 Fujii Hironori 2021-10-19 18:44:53 PDT 
Comment on attachment 441480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441480&action=review

> Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h:76
> +    if (line->containingBlock().style().rtlOrdering() == Order::Visual)

This breaks PlayStation port. See Bug 231923.