Bug 231850 - Don't load metadata base pointer in EXTRA_CTI_THUNKS
Summary: Don't load metadata base pointer in EXTRA_CTI_THUNKS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-15 18:46 PDT by Saam Barati
Modified: 2021-10-18 13:42 PDT (History)
7 users (show)

See Also:

Attachments
patch (1.93 KB, patch)
2021-10-15 18:52 PDT, Saam Barati 		ysuzuki: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch for landing (3.49 KB, patch)
2021-10-18 09:17 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-10-15 18:46:54 PDT 
It's already in a register
Comment 1 Saam Barati 2021-10-15 18:52:45 PDT 
Created attachment 441467 [details]
patch
Comment 2 Yusuke Suzuki 2021-10-15 18:54:17 PDT 
Comment on attachment 441467 [details]
patch

Nice.
Comment 3 Yusuke Suzuki 2021-10-15 19:53:12 PDT 
Comment on attachment 441467 [details]
patch

Discussed with Saam at slack, we will load this metadata in the thunk-caller side (so that we can save one more executed instruction).
Comment 4 Saam Barati 2021-10-18 09:17:29 PDT 
Created attachment 441613 [details]
patch for landing
Comment 5 EWS 2021-10-18 13:41:57 PDT 
Committed r284396 (243172@main): <https://commits.webkit.org/243172@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441613 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-18 13:42:22 PDT 
<rdar://problem/84385655>