Bug 231846 - Integrate "Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick" from Google ANGLE
Summary: Integrate "Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick" f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-15 17:16 PDT by Kyle Piddington
Modified: 2022-02-10 16:42 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2021-10-15 17:17 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (2.23 KB, patch)
2021-10-15 17:18 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-10-15 17:16:23 PDT 
Integrate "Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick" from Google ANGLE
Comment 1 Kyle Piddington 2021-10-15 17:17:35 PDT 
Created attachment 441459 [details]
Patch
Comment 2 Kyle Piddington 2021-10-15 17:18:49 PDT 
Created attachment 441460 [details]
Patch
Comment 3 EWS Watchlist 2021-10-15 17:20:06 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Kenneth Russell 2021-10-15 17:32:58 PDT 
Comment on attachment 441460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441460&action=review

> Source/ThirdParty/ANGLE/ChangeLog:3
> +        Integrate "Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick" from Google ANGLE

Is this really a cherry-pick and merge of:

Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick
https://chromium-review.googlesource.com/3169438

? It looks different - the other one inserted a second entry in the attributeBindings map.

Also, could you reference the code review above either in the commit message or the bug?
Comment 5 Radar WebKit Bug Importer 2021-10-22 17:17:17 PDT 
<rdar://problem/84569850>
Comment 6 Kyle Piddington 2022-01-12 10:46:36 PST 
Handled with part of previous ANGLE roll.