Bug 231840 - Python3 webkit-patch transition breaks webkitbot's ability to revert multiple revisions
Summary: Python3 webkit-patch transition breaks webkitbot's ability to revert multiple...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-15 15:27 PDT by Yusuke Suzuki
Modified: 2022-06-23 14:41 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-10-15 15:27:25 PDT
After python3 transition, webkitbot cannot revert multiple revisions.
Since,

1. webkitbot can parse multiple revisions as requested
2. it was working until recently, at least, until Sep 26.

So, this is likely a regression in webkit-patch command, which can be caused by python3 transition.
Comment 1 Radar WebKit Bug Importer 2021-10-15 15:28:02 PDT
<rdar://problem/84319264>
Comment 2 Yusuke Suzuki 2021-10-15 17:56:22 PDT
It seems that "reason" handling is also broken.
Now only the first word is used for the reverting reason.
Comment 3 Brent Fulgham 2022-06-23 14:41:27 PDT
Jonathan corrected this in https://commits.webkit.org/248021@main.