Bug 231836 - [macOS] Add telemetry for system calls in WP
Summary: [macOS] Add telemetry for system calls in WP
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on: 231866
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-15 14:51 PDT by Per Arne Vollan
Modified: 2021-11-09 20:28 PST (History)
5 users (show)

See Also:

Attachments
Patch (15.27 KB, patch)
2021-10-15 15:07 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (15.18 KB, patch)
2021-10-15 15:38 PDT, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (20.82 KB, patch)
2021-10-15 17:14 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (22.38 KB, patch)
2021-11-06 15:07 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (22.43 KB, patch)
2021-11-06 19:36 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (22.41 KB, patch)
2021-11-08 07:29 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (22.34 KB, patch)
2021-11-08 09:04 PST, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (24.70 KB, patch)
2021-11-09 16:38 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-10-15 14:51:13 PDT 
Add telemetry for system calls in WP to understand in which context they are being used.
Comment 1 Radar WebKit Bug Importer 2021-10-15 14:51:50 PDT 
<rdar://problem/84317842>
Comment 2 Per Arne Vollan 2021-10-15 15:07:01 PDT 
Created attachment 441433 [details]
Patch
Comment 3 Brent Fulgham 2021-10-15 15:08:58 PDT 
It looks like this patch also has your sorting change.
Comment 4 Per Arne Vollan 2021-10-15 15:38:46 PDT 
Created attachment 441441 [details]
Patch
Comment 5 Per Arne Vollan 2021-10-15 15:39:24 PDT 
(In reply to Brent Fulgham from comment #3)
> It looks like this patch also has your sorting change.

I uploaded a new patch to fix the conflicts.

Thanks for reviewing!
Comment 6 Brent Fulgham 2021-10-15 15:42:30 PDT 
Comment on attachment 441441 [details]
Patch

r=me
Comment 7 Per Arne Vollan 2021-10-15 15:56:56 PDT 
Comment on attachment 441441 [details]
Patch

Thanks for reviewing!
Comment 8 Per Arne Vollan 2021-10-15 17:14:24 PDT 
Created attachment 441458 [details]
Patch
Comment 9 EWS 2021-10-15 18:15:52 PDT 
Found 31 new test failures: accessibility/ARIA-reflection.html, accessibility/accessibility-crash-focused-element-change.html, accessibility/accessibility-crash-setattribute.html, accessibility/mac/abbr-acronym-tags.html, accessibility/mac/accessibility-make-first-responder.html, accessibility/mac/accesskey.html, accessibility/mac/attributed-string/attributed-string-for-range-with-options.html, accessibility/mac/attributed-string/attributed-string-for-range.html, accessibility/mac/search-text/search-text.html, accessibility/mac/select-text/select-text-1.html ...
Comment 10 EWS 2021-10-15 18:43:21 PDT 
Committed r284300 (243098@main): <https://commits.webkit.org/243098@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441458 [details].
Comment 11 WebKit Commit Bot 2021-10-16 13:15:28 PDT 
Re-opened since this is blocked by bug 231866
Comment 12 Per Arne Vollan 2021-11-06 15:07:09 PDT 
Created attachment 443492 [details]
Patch
Comment 13 Per Arne Vollan 2021-11-06 19:36:45 PDT 
Created attachment 443497 [details]
Patch
Comment 14 Per Arne Vollan 2021-11-08 07:29:10 PST 
Created attachment 443543 [details]
Patch
Comment 15 Per Arne Vollan 2021-11-08 09:04:41 PST 
Created attachment 443554 [details]
Patch
Comment 16 Brent Fulgham 2021-11-09 13:41:34 PST 
Comment on attachment 443554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443554&action=review

r=me

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:2055
> +    (if (not (equal? (param "CPU") "arm64"))

Couldn't this just be an 'else' clause?

You can use:
(if (condition)
    (begin
         ... things if true)
    (begin
         ... things if false)
)
Comment 17 Brent Fulgham 2021-11-09 13:42:10 PST 
Comment on attachment 443554 [details]
Patch

r=me
Comment 18 Per Arne Vollan 2021-11-09 13:59:50 PST 
Comment on attachment 443554 [details]
Patch

Thanks for reviewing!
Comment 19 EWS 2021-11-09 14:00:25 PST 
Tools/Scripts/svn-apply failed to apply attachment 443554 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 20 Per Arne Vollan 2021-11-09 14:01:50 PST 
(In reply to Brent Fulgham from comment #16)
> Comment on attachment 443554 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443554&action=review
> 
> r=me
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:2055
> > +    (if (not (equal? (param "CPU") "arm64"))
> 
> Couldn't this just be an 'else' clause?
> 
> You can use:
> (if (condition)
>     (begin
>          ... things if true)
>     (begin
>          ... things if false)
> )

Yes, that is a good point, will fix.

Thanks for reviewing!
Comment 21 Per Arne Vollan 2021-11-09 16:38:59 PST 
Created attachment 443755 [details]
Patch
Comment 22 EWS 2021-11-09 20:28:12 PST 
Committed r285561 (244069@main): <https://commits.webkit.org/244069@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443755 [details].