RESOLVED FIXED Bug 231836
[macOS] Add telemetry for system calls in WP 
https://bugs.webkit.org/show_bug.cgi?id=231836
Summary [macOS] Add telemetry for system calls in WP
Per Arne Vollan
Reported 2021-10-15 14:51:13 PDT
Add telemetry for system calls in WP to understand in which context they are being used.
Attachments
Patch (15.27 KB, patch)
2021-10-15 15:07 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (15.18 KB, patch)
2021-10-15 15:38 PDT, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (20.82 KB, patch)
2021-10-15 17:14 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (22.38 KB, patch)
2021-11-06 15:07 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (22.43 KB, patch)
2021-11-06 19:36 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (22.41 KB, patch)
2021-11-08 07:29 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (22.34 KB, patch)
2021-11-08 09:04 PST, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (24.70 KB, patch)
2021-11-09 16:38 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-15 14:51:50 PDT
<rdar://problem/84317842>
Per Arne Vollan
Comment 2 2021-10-15 15:07:01 PDT
Created attachment 441433 [details] Patch
Brent Fulgham
Comment 3 2021-10-15 15:08:58 PDT
It looks like this patch also has your sorting change.
Per Arne Vollan
Comment 4 2021-10-15 15:38:46 PDT
Created attachment 441441 [details] Patch
Per Arne Vollan
Comment 5 2021-10-15 15:39:24 PDT
(In reply to Brent Fulgham from comment #3) > It looks like this patch also has your sorting change. I uploaded a new patch to fix the conflicts. Thanks for reviewing!
Brent Fulgham
Comment 6 2021-10-15 15:42:30 PDT
Comment on attachment 441441 [details] Patch r=me
Per Arne Vollan
Comment 7 2021-10-15 15:56:56 PDT
Comment on attachment 441441 [details] Patch Thanks for reviewing!
Per Arne Vollan
Comment 8 2021-10-15 17:14:24 PDT
Created attachment 441458 [details] Patch
EWS
Comment 9 2021-10-15 18:15:52 PDT
Found 31 new test failures: accessibility/ARIA-reflection.html, accessibility/accessibility-crash-focused-element-change.html, accessibility/accessibility-crash-setattribute.html, accessibility/mac/abbr-acronym-tags.html, accessibility/mac/accessibility-make-first-responder.html, accessibility/mac/accesskey.html, accessibility/mac/attributed-string/attributed-string-for-range-with-options.html, accessibility/mac/attributed-string/attributed-string-for-range.html, accessibility/mac/search-text/search-text.html, accessibility/mac/select-text/select-text-1.html ...
EWS
Comment 10 2021-10-15 18:43:21 PDT
Committed r284300 (243098@main): <https://commits.webkit.org/243098@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441458 [details].
WebKit Commit Bot
Comment 11 2021-10-16 13:15:28 PDT
Re-opened since this is blocked by bug 231866
Per Arne Vollan
Comment 12 2021-11-06 15:07:09 PDT
Created attachment 443492 [details] Patch
Per Arne Vollan
Comment 13 2021-11-06 19:36:45 PDT
Created attachment 443497 [details] Patch
Per Arne Vollan
Comment 14 2021-11-08 07:29:10 PST
Created attachment 443543 [details] Patch
Per Arne Vollan
Comment 15 2021-11-08 09:04:41 PST
Created attachment 443554 [details] Patch
Brent Fulgham
Comment 16 2021-11-09 13:41:34 PST
Comment on attachment 443554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443554&action=review r=me > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:2055 > + (if (not (equal? (param "CPU") "arm64")) Couldn't this just be an 'else' clause? You can use: (if (condition) (begin ... things if true) (begin ... things if false) )
Brent Fulgham
Comment 17 2021-11-09 13:42:10 PST
Comment on attachment 443554 [details] Patch r=me
Per Arne Vollan
Comment 18 2021-11-09 13:59:50 PST
Comment on attachment 443554 [details] Patch Thanks for reviewing!
EWS
Comment 19 2021-11-09 14:00:25 PST
Tools/Scripts/svn-apply failed to apply attachment 443554 [details] to trunk. Please resolve the conflicts and upload a new patch.
Per Arne Vollan
Comment 20 2021-11-09 14:01:50 PST
(In reply to Brent Fulgham from comment #16) > Comment on attachment 443554 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443554&action=review > > r=me > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:2055 > > + (if (not (equal? (param "CPU") "arm64")) > > Couldn't this just be an 'else' clause? > > You can use: > (if (condition) > (begin > ... things if true) > (begin > ... things if false) > ) Yes, that is a good point, will fix. Thanks for reviewing!
Per Arne Vollan
Comment 21 2021-11-09 16:38:59 PST
Created attachment 443755 [details] Patch
EWS
Comment 22 2021-11-09 20:28:12 PST
Committed r285561 (244069@main): <https://commits.webkit.org/244069@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443755 [details].
Note You need to log in before you can comment on or make changes to this bug.