Bug 231815 - [libpas] Enable libpas on macOS
Summary: [libpas] Enable libpas on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 231859 232011
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-15 10:30 PDT by Yusuke Suzuki
Modified: 2021-11-08 11:01 PST (History)
16 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2021-10-15 10:31 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (1.43 KB, patch)
2021-10-16 01:14 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (2.17 KB, patch)
2021-10-16 22:09 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (86.53 KB, patch)
2021-10-17 02:16 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (86.46 KB, patch)
2021-10-17 02:23 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (93.02 KB, patch)
2021-10-17 02:46 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (93.46 KB, patch)
2021-10-17 02:49 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (93.73 KB, patch)
2021-10-17 02:51 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (93.30 KB, patch)
2021-10-17 02:54 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (92.00 KB, patch)
2021-10-17 03:09 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (92.00 KB, patch)
2021-10-17 03:12 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (92.55 KB, patch)
2021-10-17 11:57 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (92.59 KB, patch)
2021-10-18 01:12 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (91.05 KB, patch)
2021-10-18 13:35 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (51.10 KB, patch)
2021-10-18 17:18 PDT, Yusuke Suzuki 		fpizlo: review+
Details | Formatted Diff | Diff
Patch (51.84 KB, patch)
2021-10-19 12:06 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (50.36 KB, patch)
2021-10-19 12:19 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (51.70 KB, patch)
2021-10-19 22:33 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (50.36 KB, patch)
2021-10-20 11:17 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (17) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-10-15 10:30:08 PDT 
[libpas] Enable libpas on macOS
Comment 1 Yusuke Suzuki 2021-10-15 10:31:57 PDT 
Created attachment 441399 [details]
Patch
Comment 2 Saam Barati 2021-10-15 11:39:35 PDT 
Comment on attachment 441399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441399&action=review

r=me

> Source/bmalloc/ChangeLog:12
> +        1. Speedometer2 is 2.1% improved on low-end macOS (MBA8,2) and 1.7% improved on high-end macOS (MBP14,1).

nice!
Comment 3 Yusuke Suzuki 2021-10-15 21:35:51 PDT 
mac-debug-wk1 is getting stuck, and after 11 hours, still it is not scheduled. I'll land it for now.
Comment 4 Yusuke Suzuki 2021-10-15 21:38:34 PDT 
Committed r284305 (243103@main): <https://commits.webkit.org/243103@main>
Comment 5 Radar WebKit Bug Importer 2021-10-15 21:39:15 PDT 
<rdar://problem/84326992>
Comment 6 WebKit Commit Bot 2021-10-16 00:56:20 PDT 
Re-opened since this is blocked by bug 231859
Comment 7 Yusuke Suzuki 2021-10-16 01:14:13 PDT 
Created attachment 441482 [details]
Patch
Comment 8 Yusuke Suzuki 2021-10-16 22:09:18 PDT 
Created attachment 441517 [details]
Patch
Comment 9 Yusuke Suzuki 2021-10-17 02:16:26 PDT 
Created attachment 441521 [details]
Patch
Comment 10 Yusuke Suzuki 2021-10-17 02:23:44 PDT 
Created attachment 441522 [details]
Patch
Comment 11 Yusuke Suzuki 2021-10-17 02:46:32 PDT 
Created attachment 441523 [details]
Patch
Comment 12 Yusuke Suzuki 2021-10-17 02:49:03 PDT 
Created attachment 441524 [details]
Patch
Comment 13 Yusuke Suzuki 2021-10-17 02:51:14 PDT 
Created attachment 441525 [details]
Patch
Comment 14 Yusuke Suzuki 2021-10-17 02:54:59 PDT 
Created attachment 441526 [details]
Patch
Comment 15 Yusuke Suzuki 2021-10-17 03:09:20 PDT 
Created attachment 441527 [details]
Patch
Comment 16 Yusuke Suzuki 2021-10-17 03:12:08 PDT 
Created attachment 441528 [details]
Patch
Comment 17 Yusuke Suzuki 2021-10-17 11:57:11 PDT 
Created attachment 441542 [details]
Patch
Comment 18 Yusuke Suzuki 2021-10-18 01:12:49 PDT 
Created attachment 441567 [details]
Patch
Comment 19 Yusuke Suzuki 2021-10-18 13:35:27 PDT 
Created attachment 441637 [details]
Patch
Comment 20 Yusuke Suzuki 2021-10-18 17:18:15 PDT 
Created attachment 441662 [details]
Patch
Comment 21 Filip Pizlo 2021-10-19 10:42:34 PDT 
Comment on attachment 441662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441662&action=review

> Source/bmalloc/libpas/src/libpas/pas_utils_prefix.h:-50
> -#ifdef __OPTIMIZE__
>  #define __PAS_ALWAYS_INLINE_BUT_NOT_INLINE __attribute__((__always_inline__))
> -#else
> -#define __PAS_ALWAYS_INLINE_BUT_NOT_INLINE
> -#endif
> -

Is this change still necessary?

If it's not, then I'd kill it, since in those cases where you actually have to debug libpas (and build it in debug mode), you'll want the inlining turned off.
Comment 22 Yusuke Suzuki 2021-10-19 12:06:21 PDT 
Created attachment 441767 [details]
Patch

Try removing always-inline change
Comment 23 Yusuke Suzuki 2021-10-19 12:19:07 PDT 
Created attachment 441768 [details]
Patch

Try removing always-inline change
Comment 24 Yusuke Suzuki 2021-10-19 22:33:20 PDT 
Created attachment 441850 [details]
Patch

Try WebAudio test
Comment 25 Yusuke Suzuki 2021-10-20 05:32:40 PDT 
OK! I found a bug in WebAudio code :)
I'll create a patch in a separate bug.
Comment 26 Yusuke Suzuki 2021-10-20 05:56:42 PDT 
(In reply to Yusuke Suzuki from comment #25)
> OK! I found a bug in WebAudio code :)
> I'll create a patch in a separate bug.

The failure is WebAudio bug. https://bugs.webkit.org/show_bug.cgi?id=232011
Comment 27 Yusuke Suzuki 2021-10-20 11:17:28 PDT 
Created attachment 441901 [details]
Patch

Patch for landing
Comment 28 Yusuke Suzuki 2021-11-08 09:07:30 PST 
Committed r285407 (243964@main): <https://commits.webkit.org/243964@main>
Comment 29 Yusuke Suzuki 2021-11-08 10:52:46 PST 
Committed r285415 (243972@main): <https://commits.webkit.org/243972@main>
Comment 30 Yusuke Suzuki 2021-11-08 11:01:10 PST 
Committed r285416 (243973@main): <https://commits.webkit.org/243973@main>