Bug 231807 - [iOS] Screen Sharing doesn't switch to AirPlay when <video> enters fullscreen mode
Summary: [iOS] Screen Sharing doesn't switch to AirPlay when <video> enters fullscreen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-15 08:43 PDT by Jer Noble
Modified: 2021-10-15 17:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.70 KB, patch)
2021-10-15 08:55 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-10-15 08:43:54 PDT 
[iOS] Screen Sharing doesn't switch to AirPlay when <video> enters fullscreen mode
Comment 1 Jer Noble 2021-10-15 08:45:11 PDT 
<rdar://82995799>
Comment 2 Jer Noble 2021-10-15 08:55:11 PDT 
Created attachment 441383 [details]
Patch
Comment 3 Peng Liu 2021-10-15 09:24:45 PDT 
Comment on attachment 441383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441383&action=review

> Source/WebKit/ChangeLog:10
> +        <video> element is in fullscreen mode. However, the fullscreen state this code depends on

Is this true for element fullscreen as well?
Comment 4 Jer Noble 2021-10-15 11:45:41 PDT 
(In reply to Peng Liu from comment #3)
> Comment on attachment 441383 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441383&action=review
> 
> > Source/WebKit/ChangeLog:10
> > +        <video> element is in fullscreen mode. However, the fullscreen state this code depends on
> 
> Is this true for element fullscreen as well?

No, only for video fullscreen.
Comment 5 Jer Noble 2021-10-15 11:47:01 PDT 
(In reply to Jer Noble from comment #4)
> (In reply to Peng Liu from comment #3)
> > Comment on attachment 441383 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=441383&action=review
> > 
> > > Source/WebKit/ChangeLog:10
> > > +        <video> element is in fullscreen mode. However, the fullscreen state this code depends on
> > 
> > Is this true for element fullscreen as well?
> 
> No, only for video fullscreen.

Oh, disregard, it's true for  "standby mode" as well, so element fullscreen too. (Also fixed by this patch).
Comment 6 EWS 2021-10-15 17:00:16 PDT 
Committed r284294 (243092@main): <https://commits.webkit.org/243092@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441383 [details].