Bug 231804 - Cocoa GraphicsContextGLOpenGL should not use WebGLLayer
Summary: Cocoa GraphicsContextGLOpenGL should not use WebGLLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 231009
  Show dependency tree / graph
 
Reported: 2021-10-15 05:57 PDT by Kimmo Kinnunen
Modified: 2021-10-18 07:58 PDT (History)
12 users (show)

See Also:

Attachments
Patch (49.73 KB, patch)
2021-10-15 10:18 PDT, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (50.10 KB, patch)
2021-10-15 10:54 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (50.86 KB, patch)
2021-10-16 03:28 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (50.83 KB, patch)
2021-10-17 03:24 PDT, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (50.86 KB, patch)
2021-10-17 04:01 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (52.33 KB, patch)
2021-10-18 00:44 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-10-15 05:57:41 PDT 
Cocoa GraphicsContextGLOpenGL should not use WebGLLayer

When in GPU Process, GraphicsContextGLOpenGL does not need WebGLLayer.
Instead, GraphicsContextGLOpenGL should just use the "swap chain" directly, e.g. just hold the IOSurfaces for display buffer and drawing buffer.
Comment 1 Kimmo Kinnunen 2021-10-15 10:18:49 PDT 
Created attachment 441396 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-10-15 10:54:05 PDT 
Created attachment 441402 [details]
Patch
Comment 3 Kimmo Kinnunen 2021-10-16 03:28:00 PDT 
Created attachment 441484 [details]
Patch for landing
Comment 4 Kimmo Kinnunen 2021-10-17 03:24:38 PDT 
Created attachment 441529 [details]
Patch for landing
Comment 5 Kimmo Kinnunen 2021-10-17 04:01:28 PDT 
Created attachment 441531 [details]
Patch for landing
Comment 6 Kimmo Kinnunen 2021-10-18 00:44:49 PDT 
Created attachment 441565 [details]
Patch for landing
Comment 7 EWS 2021-10-18 07:57:30 PDT 
Committed r284371 (243156@main): <https://commits.webkit.org/243156@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441565 [details].
Comment 8 Radar WebKit Bug Importer 2021-10-18 07:58:41 PDT 
<rdar://problem/84370716>