Bug 231795 - PlatformUse.h cannot include anything
Summary: PlatformUse.h cannot include anything
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords:
Depends on: 229353
Blocks:
  Show dependency treegraph
 
Reported: 2021-10-14 21:40 PDT by Robin Morisset
Modified: 2021-10-18 16:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.31 KB, patch)
2021-10-14 21:42 PDT, Robin Morisset
rmorisset: review-
rmorisset: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2021-10-14 21:40:05 PDT
I got too hasty in landing https://bugs.webkit.org/show_bug.cgi?id=229353, and broke a bunch of tests in the process (I had verified that these tests passed on a previous version of the patch, and did not think that in fixing the watch I would break something else).
The root cause appears to be that PlatformUse.h is not a regular header: it gets included in all kinds of places, including files that are not C++ (nor even C!) such as the files defining the sandbox of the network process. And so my including <cstdint> naturally caused massive issues.
This patch reverts that particular piece of the previous patch, making USE_LARGE_TYPED_ARRAYS exclusively depend on CPU(ADDRESS64).
It is less semantically clean, but seems to be equivalent on all platforms we support (verified with static_asserts in ArrayBuffer.h).
Comment 1 Robin Morisset 2021-10-14 21:42:29 PDT
Created attachment 441330 [details]
Patch
Comment 2 Robin Morisset 2021-10-14 23:25:05 PDT
Comment on attachment 441330 [details]
Patch

I am reverting https://bugs.webkit.org/show_bug.cgi?id=229353, so this will be merged into the next version of it.
Comment 3 Robin Morisset 2021-10-18 16:31:27 PDT
I rolled out the offending patch, and later landed it again with this fix included.