Turns out this is needed to implement some parts of Web Extensions.
<rdar://problem/84280608>
Created attachment 441307 [details] Patch v1.0 This patch must land after a corresponding Safari change to stop using this header/method.
Created attachment 441401 [details] Patch v1.0.1 (rebased)
Comment on attachment 441401 [details] Patch v1.0.1 (rebased) View in context: https://bugs.webkit.org/attachment.cgi?id=441401&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.h:85 > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)tabIdentifier completionHandler:(void(^)(NSError * _Nullable, NSDictionary * _Nullable result))completionHandler; Can this be above `reloadIgnoringCache` so it is next to the other `evaluateScript`? > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:126 > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)extensionTabIdentifier completionHandler:(void(^)(NSError *, NSDictionary *))completionHandler Ditto _WKInspectorExtension.h:85
(In reply to Patrick Angle from comment #4) > Comment on attachment 441401 [details] > Patch v1.0.1 (rebased) > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441401&action=review > > > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.h:85 > > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)tabIdentifier completionHandler:(void(^)(NSError * _Nullable, NSDictionary * _Nullable result))completionHandler; > > Can this be above `reloadIgnoringCache` so it is next to the other > `evaluateScript`? > > > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:126 > > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)extensionTabIdentifier completionHandler:(void(^)(NSError *, NSDictionary *))completionHandler > > Ditto _WKInspectorExtension.h:85 Sure!
Created attachment 441405 [details] Patch v1.1
(In reply to BJ Burg from comment #6) > Created attachment 441405 [details] > Patch v1.1 Looks like I forgot one.
Created attachment 441455 [details] Patch v1.1.1 (rebased)
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Committed r284337 (243132@main): <https://commits.webkit.org/243132@main>