Bug 231784 – [Cocoa] Web Inspector: remove _WKInspectorExtensionPrivateForTesting

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Turns out this is needed to implement some parts of Web Extensions.

[Radar WebKit Bug Importer]

<rdar://problem/84280608>

[Blaze Burg]

Created attachment 441307 [details]
Patch v1.0

This patch must land after a corresponding Safari change to stop using this header/method.

[Blaze Burg]

Created attachment 441401 [details]
Patch v1.0.1 (rebased)

[Patrick Angle]

Comment on attachment 441401 [details]
Patch v1.0.1 (rebased)

View in context: https://bugs.webkit.org/attachment.cgi?id=441401&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.h:85
> +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)tabIdentifier completionHandler:(void(^)(NSError * _Nullable, NSDictionary * _Nullable result))completionHandler;

Can this be above `reloadIgnoringCache` so it is next to the other `evaluateScript`?

> Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:126
> +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)extensionTabIdentifier completionHandler:(void(^)(NSError *, NSDictionary *))completionHandler

Ditto _WKInspectorExtension.h:85

[Blaze Burg]

(In reply to Patrick Angle from comment #4)
> Comment on attachment 441401 [details]
> Patch v1.0.1 (rebased)
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441401&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.h:85
> > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)tabIdentifier completionHandler:(void(^)(NSError * _Nullable, NSDictionary * _Nullable result))completionHandler;
> 
> Can this be above `reloadIgnoringCache` so it is next to the other
> `evaluateScript`?
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:126
> > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)extensionTabIdentifier completionHandler:(void(^)(NSError *, NSDictionary *))completionHandler
> 
> Ditto _WKInspectorExtension.h:85

Sure!

[Blaze Burg]

Created attachment 441405 [details]
Patch v1.1

[Blaze Burg]

(In reply to BJ Burg from comment #6)
> Created attachment 441405 [details]
> Patch v1.1

Looks like I forgot one.

[Blaze Burg]

Created attachment 441455 [details]
Patch v1.1.1 (rebased)

[EWS]

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

[Blaze Burg]

Committed r284337 (243132@main): <https://commits.webkit.org/243132@main>