Bug 231784 - [Cocoa] Web Inspector: remove _WKInspectorExtensionPrivateForTesting
Summary: [Cocoa] Web Inspector: remove _WKInspectorExtensionPrivateForTesting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-14 16:45 PDT by BJ Burg
Modified: 2021-10-17 12:00 PDT (History)
5 users (show)

See Also:


Attachments
Patch v1.0 (21.85 KB, patch)
2021-10-14 16:56 PDT, BJ Burg
no flags Details | Formatted Diff | Diff
Patch v1.0.1 (rebased) (20.45 KB, patch)
2021-10-15 10:53 PDT, BJ Burg
no flags Details | Formatted Diff | Diff
Patch v1.1 (21.93 KB, patch)
2021-10-15 11:08 PDT, BJ Burg
no flags Details | Formatted Diff | Diff
Patch v1.1.1 (rebased) (23.20 KB, patch)
2021-10-15 16:43 PDT, BJ Burg
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2021-10-14 16:45:21 PDT
Turns out this is needed to implement some parts of Web Extensions.
Comment 1 Radar WebKit Bug Importer 2021-10-14 16:45:40 PDT
<rdar://problem/84280608>
Comment 2 BJ Burg 2021-10-14 16:56:46 PDT
Created attachment 441307 [details]
Patch v1.0

This patch must land after a corresponding Safari change to stop using this header/method.
Comment 3 BJ Burg 2021-10-15 10:53:59 PDT
Created attachment 441401 [details]
Patch v1.0.1 (rebased)
Comment 4 Patrick Angle 2021-10-15 11:02:32 PDT
Comment on attachment 441401 [details]
Patch v1.0.1 (rebased)

View in context: https://bugs.webkit.org/attachment.cgi?id=441401&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.h:85
> +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)tabIdentifier completionHandler:(void(^)(NSError * _Nullable, NSDictionary * _Nullable result))completionHandler;

Can this be above `reloadIgnoringCache` so it is next to the other `evaluateScript`?

> Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:126
> +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)extensionTabIdentifier completionHandler:(void(^)(NSError *, NSDictionary *))completionHandler

Ditto _WKInspectorExtension.h:85
Comment 5 BJ Burg 2021-10-15 11:04:44 PDT
(In reply to Patrick Angle from comment #4)
> Comment on attachment 441401 [details]
> Patch v1.0.1 (rebased)
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441401&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.h:85
> > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)tabIdentifier completionHandler:(void(^)(NSError * _Nullable, NSDictionary * _Nullable result))completionHandler;
> 
> Can this be above `reloadIgnoringCache` so it is next to the other
> `evaluateScript`?
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:126
> > +- (void)evaluateScript:(NSString *)scriptSource inTabWithIdentifier:(NSString *)extensionTabIdentifier completionHandler:(void(^)(NSError *, NSDictionary *))completionHandler
> 
> Ditto _WKInspectorExtension.h:85

Sure!
Comment 6 BJ Burg 2021-10-15 11:08:25 PDT
Created attachment 441405 [details]
Patch v1.1
Comment 7 BJ Burg 2021-10-15 16:39:32 PDT
(In reply to BJ Burg from comment #6)
> Created attachment 441405 [details]
> Patch v1.1

Looks like I forgot one.
Comment 8 BJ Burg 2021-10-15 16:43:47 PDT
Created attachment 441455 [details]
Patch v1.1.1 (rebased)
Comment 9 EWS 2021-10-15 20:33:39 PDT
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Comment 10 BJ Burg 2021-10-17 12:00:51 PDT
Committed r284337 (243132@main): <https://commits.webkit.org/243132@main>