Bug 23176 - WebCore::Event::timeStamp() should be const
Summary: WebCore::Event::timeStamp() should be const
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-07 15:25 PST by James Robinson
Modified: 2009-01-08 16:30 PST (History)
0 users

See Also:

Attachments
Changes the accessor to be const (1015 bytes, patch)
2009-01-07 15:26 PST, James Robinson 		sam: review+
Details | Formatted Diff | Diff
Changes the accessor to be const and adds name/bug url to ChangeLog (1.08 KB, patch)
2009-01-07 15:45 PST, James Robinson 		mrowe: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2009-01-07 15:25:40 PST 
WebCore::Event's timeStamp() is a trivial accessor and should be const so code with a const reference or pointer can query the field.
Comment 1 James Robinson 2009-01-07 15:26:36 PST 
Created attachment 26509 [details]
Changes the accessor to be const
Comment 2 Sam Weinig 2009-01-07 15:32:40 PST 
Comment on attachment 26509 [details]
Changes the accessor to be const

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 39688)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,12 @@
> +2009-01-07  James Robinson  <jamesr@google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        WARNING: NO TEST CASES ADDED OR CHANGED

Please add at least the name and url of the bug and short description of your change.
Comment 3 James Robinson 2009-01-07 15:45:02 PST 
Created attachment 26510 [details]
Changes the accessor to be const and adds name/bug url to ChangeLog
Comment 4 Pam Greene (IRC:pamg) 2009-01-08 16:30:57 PST 
Landed in r39726.