Bug 231756 – AX: role="math" elements are no longer considered to have presentational children

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

In WAI-ARIA 1.1 (https://www.w3.org/TR/wai-aria-1.1/#math-0), role="math" elements were considered to have presentational children. This changed in WAI-ARIA 1.2 (https://www.w3.org/TR/wai-aria-1.2/#math).

[Radar WebKit Bug Importer]

<rdar://problem/84268174>

[Tyler Wilcock]

Created attachment 441252 [details]
Patch

[Darin Adler]

Comment on attachment 441252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441252&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:401
>  #if ENABLE(MATHML)
> -        return node()->isMathMLElement();
> +        return true;
>  #endif
>          return false;

Seems like this should use #else.

But also, is it really important to return false for this when building without MathML support?

[Tyler Wilcock]

Created attachment 441261 [details]
Patch

[Tyler Wilcock]

Created attachment 441263 [details]
Patch

[Tyler Wilcock]

(In reply to Darin Adler from comment #3)
> Comment on attachment 441252 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441252&action=review
> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:401
> >  #if ENABLE(MATHML)
> > -        return node()->isMathMLElement();
> > +        return true;
> >  #endif
> >          return false;
> 
> Seems like this should use #else.
> 
> But also, is it really important to return false for this when building
> without MathML support?

No, it isn't. Submitted a patch with this changed.

[EWS]

Committed r284246 (243055@main): <https://commits.webkit.org/243055@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441263 [details].