Bug 231754 – Repaint issue with animating SVG inside <img> with object-fit

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Layout and Rendering

[Simon Fraser (smfr)]

https://codepen.io/benfrain/pen/PoKPbPR shows a repaint issue that is related to object-fit on the <img>

[Simon Fraser (smfr)]

Partial fix:

diff --git a/Source/WebCore/rendering/RenderImage.cpp b/Source/WebCore/rendering/RenderImage.cpp
index 4e89c2e80b7801407d8eea0ae06c349666125012..5c8730151f09b77a03da0e02a38d1ccc5d792c73 100644
--- a/Source/WebCore/rendering/RenderImage.cpp
+++ b/Source/WebCore/rendering/RenderImage.cpp
@@ -371,7 +371,7 @@ void RenderImage::repaintOrMarkForLayout(ImageSizeChangeType imageSizeChange, co
         updateInnerContentRect();
     }
 
-    LayoutRect repaintRect = contentBoxRect();
+    LayoutRect repaintRect = replacedContentRect();
     if (rect) {
         // The image changed rect is in source image coordinates (pre-zooming),
         // so map from the bounds of the image to the contentsBox.


There's a bad initial repaint, and this needs tests.

[Radar WebKit Bug Importer]

<rdar://problem/84517855>

[Karl Dubost]

Created attachment 464167 [details]
rendering in safari

This shows the remanent image in the background

[Ahmad Saleem]

Can we pick tests from these two blink commit, which did similar looking changes in 'RenderImage'?

https://src.chromium.org/viewvc/blink?revision=180015&view=revision & https://chromium.googlesource.com/chromium/blink/+/889169f1b0b5ef4fb9e126fea64c48d68f584456

I haven't checked whether they fail currently or not.

[Taher]

Pull request: https://github.com/WebKit/WebKit/pull/56504

[Ahmad Saleem]

PR landed but it was landed against other bug - which is same as this, I am unable to reproduce this on STP236.

*** This bug has been marked as a duplicate of bug 284625 ***