Bug 231744 - Remove Variant.h
Summary: Remove Variant.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2021-10-14 09:00 PDT by Alex Christensen
Modified: 2021-10-14 16:31 PDT (History)
51 users (show)

See Also:

Patch (91.00 KB, patch)
2021-10-14 09:01 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (85.31 KB, patch)
2021-10-14 11:30 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-10-14 09:00:40 PDT
Remove Variant.h
Comment 1 Alex Christensen 2021-10-14 09:01:38 PDT
Created attachment 441224 [details]
Comment 2 Alex Christensen 2021-10-14 11:30:28 PDT
Created attachment 441248 [details]
Comment 3 Darin Adler 2021-10-14 12:31:54 PDT
Comment on attachment 441248 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=441248&action=review

I’d be surprised if there aren’t at least some cases where we can just do without the include of <variant>, especially since including <wtf/StdLibExtras.h> will now pull it in

> Source/WTF/wtf/StdLibExtras.h:32
> +#include <variant>

Too bad there’s no way to dodge this. I wonder what effect it has on build times; what that tool Jer’s been using says about it. In the future, we might want to break up StdLibExtras.h into multiple headers if it’s hurting build times.
Comment 4 EWS 2021-10-14 16:30:18 PDT
Committed r284213 (243023@main): <https://commits.webkit.org/243023@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441248 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-14 16:31:18 PDT