Bug 231723 - Further adjust style of alternate form control design
Summary: Further adjust style of alternate form control design
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-14 00:05 PDT by Tim Horton
Modified: 2021-10-14 10:58 PDT (History)
13 users (show)

See Also:

Attachments
Patch (7.45 KB, patch)
2021-10-14 00:07 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (7.49 KB, patch)
2021-10-14 00:14 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-10-14 00:05:36 PDT 
Further adjust style of alternate form control design
Comment 1 Tim Horton 2021-10-14 00:07:31 PDT 
Created attachment 441187 [details]
Patch
Comment 2 Tim Horton 2021-10-14 00:08:01 PDT 
<rdar://problem/84227020>
Comment 3 Tim Horton 2021-10-14 00:14:58 PDT 
Created attachment 441188 [details]
Patch
Comment 4 Dean Jackson 2021-10-14 10:29:35 PDT 
Comment on attachment 441188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441188&action=review

> Source/WebCore/css/parser/CSSParserContext.cpp:51
> +        individualTransformPropertiesEnabled = true;

We should make this the default in a separate patch. We've shipped it for a release or two now.
Comment 5 Tim Horton 2021-10-14 10:44:12 PDT 
Comment on attachment 441188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441188&action=review

>> Source/WebCore/css/parser/CSSParserContext.cpp:51
>> +        individualTransformPropertiesEnabled = true;
> 
> We should make this the default in a separate patch. We've shipped it for a release or two now.

It IS the default, the problem is that CSSParserContext doesn't care, *everything* defaults to false (thus the fixme).

Possible that we should just delete the switch for individualTransformPropertiesEnabled though....
Comment 6 EWS 2021-10-14 10:58:25 PDT 
Committed r284176 (242993@main): <https://commits.webkit.org/242993@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441188 [details].