Bug 231720 – REGRESSION(r283878) [WPE] Lots of API test crashes with visibility=hidden and friends enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Lauro Moura]

Sample trace from a WebKitBuild/WPE/Release/bin/TestWebKitAPI/WPE/TestWebKitWebContext test:

TEST: /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WPE/TestWebKitWebContext...
  /webkit/WebKitWebContext/default-context:                           CRASH
1   0x5639de5f7419 WTFCrash
2   0x7f53b3fba2dc /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-1.1.so.0(+0xf092dc) [0x7f53b3fba2dc]
3   0x7f53b3ea195e /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-1.1.so.0(+0xdf095e) [0x7f53b3ea195e]
4   0x7f53b3f155a1 webkit_security_manager_register_uri_scheme_as_local
5   0x7f53b3f2ae7b /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-1.1.so.0(+0xe79e7b) [0x7f53b3f2ae7b]
6   0x7f53afcf7d07 /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0(+0x1bd07) [0x7f53afcf7d07]
7   0x7f53afcf96d8 g_object_new_valist
8   0x7f53afcf9c0d g_object_new
9   0x5639dd28f1ee /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x1371ee) [0x5639dd28f1ee]
10  0x7f53b96a7c9a /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x81c9a) [0x7f53b96a7c9a]
11  0x7f53b96a79cb /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x819cb) [0x7f53b96a79cb]
12  0x7f53b96a79cb /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x819cb) [0x7f53b96a79cb]
13  0x7f53b96a817a g_test_run_suite
14  0x7f53b96a81a1 g_test_run
15  0x5639dd286533 /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x12e533) [0x5639dd286533]
16  0x7f53af2adb90 __libc_start_main
17  0x5639dd286e5e /app/webkit/Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x12ee5e) [0x5639dd286e5e]

Debug bot trace:

TEST: /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext...
  /webkit/WebKitWebContext/default-context:                           CRASH
ASSERTION FAILED: isUIThread()
/app/webkit/Source/WTF/wtf/text/AtomString.cpp(146) : WTF::AtomString::init()::<lambda()>
1   0x564c6d38255b WTFCrash
2   0x564c6b6adf91 /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x136f91) [0x564c6b6adf91]
3   0x564c6d410b77 /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x1e99b77) [0x564c6d410b77]
4   0x564c6d411181 /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x1e9a181) [0x564c6d411181]
5   0x564c6d411093 /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x1e9a093) [0x564c6d411093]
6   0x564c6d410c93 /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x1e99c93) [0x564c6d410c93]
7   0x564c6d4110bd /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x1e9a0bd) [0x564c6d4110bd]
8   0x564c6d4110ce /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x1e9a0ce) [0x564c6d4110ce]
9   0x7f1d026b1073 /usr/lib/x86_64-linux-gnu/libpthread.so.0(+0x10073) [0x7f1d026b1073]
10  0x564c6d4106e6 /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x1e996e6) [0x564c6d4106e6]
11  0x564c6d410ce6 /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x1e99ce6) [0x564c6d410ce6]
12  0x564c6d410c59 WTF::AtomString::init()
13  0x7f1d05d0865c /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x158665c) [0x7f1d05d0865c]
14  0x7f1d060590b9 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x18d70b9) [0x7f1d060590b9]
15  0x7f1d060592ed /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x18d72ed) [0x7f1d060592ed]
16  0x7f1d060591ff /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x18d71ff) [0x7f1d060591ff]
17  0x7f1d06059149 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x18d7149) [0x7f1d06059149]
18  0x7f1d06059229 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x18d7229) [0x7f1d06059229]
19  0x7f1d0605923a /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x18d723a) [0x7f1d0605923a]
20  0x7f1d026b1073 /usr/lib/x86_64-linux-gnu/libpthread.so.0(+0x10073) [0x7f1d026b1073]
21  0x7f1d06058f78 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x18d6f78) [0x7f1d06058f78]
22  0x7f1d0605919c /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x18d719c) [0x7f1d0605919c]
23  0x7f1d0605910f /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x18d710f) [0x7f1d0605910f]
24  0x7f1d060c8546 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x1946546) [0x7f1d060c8546]
25  0x7f1d060c7a72 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x1945a72) [0x7f1d060c7a72]
26  0x7f1d013e14c8 g_type_class_ref
27  0x7f1d013cab2a g_object_new_valist
28  0x7f1d060c8fc8 webkit_website_data_manager_new
29  0x564c6b6aeda6 /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x137da6) [0x564c6b6aeda6]
30  0x564c6b6ae80b /app/webkit/Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WPE/TestWebKitWebContext(+0x13780b) [0x564c6b6ae80b]
31  0x7f1d158f0c9a /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x81c9a) [0x7f1d158f0c9a]


Full log of the first build on the release bot (192 crashes): https://build.webkit.org/#/builders/40/builds/3573/steps/21/logs/stdio
Full log of the first build on the debug bot (205 crashes): https://build.webkit.org/#/builders/14/builds/1394/steps/21/logs/stdio

[Carlos Garcia Campos]

I think this is because WTF, bmalloc and JavaScriptCore are built as static libs and we end up with several copies of WTF. I've tried to build with OBJECT library type, after some changes in the makefiles. I managed to build API tests, but WTR still fails to link. API tests pass when using OBJECT libraries, so I think it's a matter of making the build work with OBJECT libs.

[Carlos Garcia Campos]

r283878 was reverted.

[Michael Catanzaro]

I see WPE does not have an API tests EWS. :/