Following up on a FIXME in SafeBrowsingWarningCocoa, move knowledge of Safe Browsing's Report an Error URLs, Learn More URLs, etc. into the SafariSafeBrowsing framework.
Created attachment 441457 [details] Patch
As per previous conversation, holding this patch at least until the relevant internal changes are in a build.
Comment on attachment 441457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441457&action=review > Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:40 > static const char* malwareDetailsBase(SSBServiceLookupResult *result) You probably want to have this return String otherwise the memory returned by strdup will be leaked. > Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:62 > static const char* reportAnErrorBase(SSBServiceLookupResult *result) You probably want to have this return String otherwise the memory returned by strdup will be leaked.
Comment on attachment 441457 [details] Patch r- since this leaks.
Comment on attachment 441457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441457&action=review > Source/WTF/wtf/PlatformHave.h:1061 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 160000) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 90000) I think that you want PLATFORM(IOS) here. IOS_FAMILY includes watchOS and tvOS, but the version check excludes them.
<rdar://problem/84472985>
Created attachment 448783 [details] Patch
Created attachment 448784 [details] Patch
Comment on attachment 448784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448784&action=review > Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h:54 > +@property (nonatomic, readonly) NSString *malwareDetailsBaseURLString NS_AVAILABLE(13_0, 16_0); For some reason we usually omit NS_AVAILABLE in our SPI headers.
Created attachment 448797 [details] Patch
This probably needs to wait for rdar://problem/87348334 to be integrated before landing.
Committed r289485 (247026@main): <https://commits.webkit.org/247026@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448797 [details].
Reverted in http://trac.webkit.org/r289573
r289910