Bug 231682 - REGRESSION (r283667): webgl/2.0.0/deqp/functional/gles3/lifetime.html fails
Summary: REGRESSION (r283667): webgl/2.0.0/deqp/functional/gles3/lifetime.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on: 229378
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-13 10:18 PDT by Jon Lee
Modified: 2021-10-15 16:57 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2021-10-13 13:25 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch for landing (2.04 KB, patch)
2021-10-15 15:42 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2021-10-13 10:18:49 PDT 
WebGL bot shows webgl/2.0.0/deqp/functional/gles3/lifetime.html fails after r283667.
Comment 1 Radar WebKit Bug Importer 2021-10-13 10:21:30 PDT 
<rdar://problem/84204653>
Comment 2 Kenneth Russell 2021-10-13 10:30:30 PDT 
Kyle, could you investigate this regression? If shaders are failing to compile then arbitrary WebGL applications might be impacted.
Comment 3 Kyle Piddington 2021-10-13 13:25:17 PDT 
Created attachment 441126 [details]
Patch
Comment 4 EWS Watchlist 2021-10-13 13:26:26 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 5 Kimmo Kinnunen 2021-10-14 10:51:54 PDT 
Comment on attachment 441126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441126&action=review

some whitespace issues..

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:261
> +                << "ANGLE_vertexOut.";

whitespace: maybe match the indent or align the whole statement.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:262
> +                if(!varying.isBuiltIn())

nit: space after if
Comment 6 Kyle Piddington 2021-10-15 15:42:44 PDT 
Created attachment 441442 [details]
Patch for landing
Comment 7 EWS 2021-10-15 16:57:19 PDT 
Committed r284293 (243091@main): <https://commits.webkit.org/243091@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441442 [details].