WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23168
Improve DRT API existence test in animation-test-helpers.js & transition-test-helpers.js
https://bugs.webkit.org/show_bug.cgi?id=23168
Summary
Improve DRT API existence test in animation-test-helpers.js & transition-test...
Simon Fraser (smfr)
Reported
2009-01-07 11:34:38 PST
animation-test-helper.js has this: var hasPauseAnimationAPI = window.layoutTestController && layoutTestController.pauseAnimationAtTimeOnElementWithId; That expression does not evaluate to boolean; hasPauseAnimationAPI is 'undefined' if the API is not present. A better form is: var hasPauseAnimationAPI = ('layoutTestController' in window) && ('pauseAnimationAtTimeOnElementWithId' in layoutTestController);
Attachments
Add attachment
proposed patch, testcase, etc.
Pierre-Olivier Latour
Comment 1
2009-01-07 13:42:56 PST
Same issue in transition-test-helpers.js
Pierre-Olivier Latour
Comment 2
2009-01-07 14:57:15 PST
Sending LayoutTests/ChangeLog Sending LayoutTests/animations/animation-test-helpers.js Sending LayoutTests/transitions/transition-test-helpers.js Transmitting file data ... Committed revision 39687.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug